Re: [PATCH] mt76: fix building without CONFIG_LEDS_CLASS

[Lorenzo Bianconi <lorenzo.bianconi@redhat.com>]

> Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
> 
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while
> > mt76 is built-in, we run into a link error:
> >
> > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_register_device':
> > mac80211.c:(.text+0xb78): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_of_led_classdev_register'
> >
> > We don't really need a hard dependency here as the driver can presumably
> > work just fine without LEDs, so this follows the iwlwifi example and
> > adds a separate Kconfig option for the LED support, this will be available
> > whenever it will link, and otherwise the respective code gets left out from
> > the driver object.
> >
> > Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> 
> Should this go to 4.20? A linker error is pretty bad, even though I
> think this is few months old issue already.

 I guess so. The patch is based on top of Felix's repository so it apply with a
 'fuzz' on net-next/wireless-drivers-next but the patch is ok. Do I need to
 resend or it is ok?

 Regards,
 Lorenzo

> 
> And are conflicts with -next version of mt76 likely?
> 
> -- 
> Kalle Valo