Re: [PATCH 2/4] nl80211: Add netlink attribute for AMPDU aggregation enable/disable

[Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>]

Hello Tamizh,

> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
> ---
>  include/net/cfg80211.h       |    6 ++++++
>  include/uapi/linux/nl80211.h |   21 +++++++++++++++++++++
>  net/wireless/nl80211.c       |   17 +++++++++++++++++
>  net/wireless/rdev-ops.h      |   15 +++++++++++++++
>  net/wireless/trace.h         |   23 +++++++++++++++++++++++
>  5 files changed, 82 insertions(+)
...

> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 9dfcf0a6..7ba0fb7 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -4449,6 +4449,20 @@ enum nl80211_ps_state {
>   *     the max value should be advertised by the driver through
>   *     max_data_retry_count. when this attribute is not present, the driver
>   *     would use the default configuration.
> + * @NL80211_ATTR_TID_AMPDU_AGGR_CTRL: Enable/Disable aggregation for the TID
> + *     specified in %%NL80211_ATTR_TID. Its type is u8, if the peer MAC address
> + *     is passed in %NL80211_ATTR_MAC, the aggregation configuration is applied
> + *     to the data frame for the tid to that connected station.
> + *     Station specific aggregation configuration is valid only for STA's
> + *     current connection. i.e. the configuration will be reset to default when
> + *     the station connects back after disconnection/roaming.
> + *     when user-space does not include %NL80211_ATTR_MAC, this configuration
> + *     should be treated as per-netdev configuration. This configuration will
> + *     be cleared when the interface goes down and on the disconnection from a
> + *     BSS. Driver supporting this feature should advertise
> + *     NL80211_EXT_FEATURE_PER_STA_AMPDU_AGGR_CTRL and supporting per station

typo: should be NL80211_EXT_FEATURE_PER_TID_AMPDU_AGGR_CTRL

> + *     aggregation configuration should advertise
> + *     NL80211_EXT_FEATURE_PER_STA_AMPDU_AGGR_CTRL.
>   */

Regards,
Sergey