From: Felix Fietkau <nbd@nbd.name>
To: linux-wireless@vger.kernel.org
Subject: [PATCH 2/4] mt76: do not wake tx queues during flush
Date: Tue, 13 Nov 2018 20:41:21 +0100 [thread overview]
Message-ID: <20181113194123.93313-2-nbd@nbd.name> (raw)
In-Reply-To: <20181113194123.93313-1-nbd@nbd.name>
While the queue is being cleaned up, the stack must not attempt to add
any extra packets
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/net/wireless/mediatek/mt76/dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
index d62f8d9f2ea1..e2ba26378575 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.c
+++ b/drivers/net/wireless/mediatek/mt76/dma.c
@@ -168,7 +168,7 @@ mt76_dma_tx_cleanup(struct mt76_dev *dev, enum mt76_txq_id qid, bool flush)
if (entry.txwi) {
mt76_put_txwi(dev, entry.txwi);
- wake = true;
+ wake = !flush;
}
if (!flush && q->tail == last)
--
2.17.0
next prev parent reply other threads:[~2018-11-13 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 19:41 [PATCH 1/4] mt76: avoid queue/status spinlocks while passing tx status to mac80211 Felix Fietkau
2018-11-13 19:41 ` Felix Fietkau [this message]
2018-11-13 19:41 ` [PATCH 3/4] mt76: fix race condition in station removal Felix Fietkau
2018-11-16 11:05 ` Felix Fietkau
2018-11-13 19:41 ` [PATCH 4/4] mt76: add mt76_sta_remove helper Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113194123.93313-2-nbd@nbd.name \
--to=nbd@nbd.name \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox