From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600A6C43441 for ; Mon, 26 Nov 2018 08:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E53720672 for ; Mon, 26 Nov 2018 08:30:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="L3elXcpP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E53720672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726203AbeKZTYK (ORCPT ); Mon, 26 Nov 2018 14:24:10 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:35598 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbeKZTYK (ORCPT ); Mon, 26 Nov 2018 14:24:10 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAQ8SomU084427; Mon, 26 Nov 2018 08:30:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=4uytr7ll/HOWMLrLcnS07dAyzOYbMF7dCozCAanKZfE=; b=L3elXcpPWWyfmyEJb+rTLbEfG6lW6npZECnBzbfyzTURmxXrSrg9TRXCMEBAIKmDEvAv cperf15kEJzG6YNbPPZHor/Lx2j4IqLhsKXLRycuh41twcYiHFalRwdvx79EjSHaJgb9 iNPvUFld9TDklBMT7wPQN85MwcRekJlX/Qg1RxbfPL4uEu/wS9Zou6nhoKsvlKmrPZUD +oAQ8g+colw7f36LcBmGBuM5sl3W7ZooavqaANL0gOWq/aHkKR7j8v9DRMlwc5o4KgeS AXIfxvBIsdcDDIP6x+yVRFhuRmG15oJR4LjZW4nK3ydfKSHEkeg3R2d9AU5F4j+ziTzH zw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2nxy9qv5xh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Nov 2018 08:30:31 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAQ8UU41027853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Nov 2018 08:30:30 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAQ8UThn032529; Mon, 26 Nov 2018 08:30:29 GMT Received: from unbuntlaptop (/41.202.241.51) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Nov 2018 00:30:29 -0800 Date: Mon, 26 Nov 2018 11:30:22 +0300 From: Dan Carpenter To: Kalle Valo Cc: Govind Singh , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ath10k: fix a NULL vs IS_ERR() check Message-ID: <20181126083021.GC3088@unbuntlaptop> References: <20181126081143.tvu55aimdc3safcq@kili.mountain> <8736rob60p.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8736rob60p.fsf@kamboji.qca.qualcomm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9088 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=972 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811260080 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Nov 26, 2018 at 10:24:38AM +0200, Kalle Valo wrote: > Dan Carpenter writes: > > > The devm_memremap() function doesn't return NULLs, it returns error > > pointers. > > > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > > Signed-off-by: Dan Carpenter > > --- > > drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c > > index f0429bee35c2..37b3bd629f48 100644 > > --- a/drivers/net/wireless/ath/ath10k/qmi.c > > +++ b/drivers/net/wireless/ath/ath10k/qmi.c > > @@ -931,9 +931,9 @@ static int ath10k_qmi_setup_msa_resources(struct ath10k_qmi *qmi, u32 msa_size) > > qmi->msa_mem_size = resource_size(&r); > > qmi->msa_va = devm_memremap(dev, qmi->msa_pa, qmi->msa_mem_size, > > MEMREMAP_WT); > > - if (!qmi->msa_va) { > > + if (IS_ERR(qmi->msa_va)) { > > dev_err(dev, "failed to map memory region: %pa\n", &r.start); > > - return -EBUSY; > > + return PTR_ERR(qmi->msa_va); > > That's a very good find! > > But how has this even worked before? This only changes the error path. Presumably it always succeeds in real life. regards, dan carpenter