From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] mt76: dma: add rx buffer recycle support
Date: Wed, 5 Dec 2018 15:13:22 +0100 [thread overview]
Message-ID: <20181205141321.GB4159@redhat.com> (raw)
In-Reply-To: <CAJ0CqmWJHo8a_ffVguONBfYg0w4rm8QK99wqWBHY8-146YZogA@mail.gmail.com>
On Wed, Dec 05, 2018 at 11:37:33AM +0100, Lorenzo Bianconi wrote:
> >
> > Add support for recycling rx buffers if they are not forwarded
> > to network stack instead of reallocate them from scratch
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > ---
>
> Felix,
>
> could you please drop this patch since it does not help to reduce pressure
> on page_frag_cache.
What is the problem ? Maybe using kmalloc() instead of page_frag_alloc()
could help (kmalloc has standard kmem_cache for 2048 bytes object) ?
Thanks
Stanislaw
next prev parent reply other threads:[~2018-12-05 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 14:34 [PATCH 0/2] add rx buffer recycle support to mt76x2e/mt76x0e drivers Lorenzo Bianconi
2018-12-03 14:34 ` [PATCH 1/2] mt76: dma: do not build skb if reported len does not fit in buf_size Lorenzo Bianconi
2018-12-28 13:34 ` Lorenzo Bianconi
2018-12-28 15:16 ` Felix Fietkau
2018-12-03 14:34 ` [PATCH 2/2] mt76: dma: add rx buffer recycle support Lorenzo Bianconi
2018-12-05 10:37 ` Lorenzo Bianconi
2018-12-05 14:13 ` Stanislaw Gruszka [this message]
2018-12-05 15:17 ` Lorenzo Bianconi
2018-12-06 10:51 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205141321.GB4159@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).