From: Rob Herring <robh@kernel.org>
To: Bhagavathi Perumal S <bperumal@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example
Date: Mon, 10 Dec 2018 17:25:23 -0600 [thread overview]
Message-ID: <20181210232523.GA14192@bogus> (raw)
In-Reply-To: <1544466691-11821-2-git-send-email-bperumal@codeaurora.org>
On Tue, Dec 11, 2018 at 12:01:29AM +0530, Bhagavathi Perumal S wrote:
> In qcom,ath10k documentation, ath10k is used as node name in the example of
> pci based device. Normally, node name shoud be class of device and not the model
s/shoud/should/
> name, so fix it to node name "wifi". And remove the property device_type pci
> since only pci bridges should have this property.
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
> ---
> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 2196d1a..ef60f25 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -74,9 +74,8 @@ pci {
> #address-cells = <3>;
> device_type = "pci";
>
> - ath10k@0,0 {
> + wifi@0,0 {
> reg = <0 0 0 0 0>;
> - device_type = "pci";
> qcom,ath10k-calibration-data = [ 01 02 03 ... ];
> };
> };
> --
> 1.9.1
>
next prev parent reply other threads:[~2018-12-10 23:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:31 [PATCH v3 0/3] ath10k: Add support to configure BB timing for external FEM Bhagavathi Perumal S
2018-12-10 18:31 ` [PATCH v3 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example Bhagavathi Perumal S
2018-12-10 23:25 ` Rob Herring [this message]
2018-12-11 5:56 ` Bhagavathi Perumal S
2018-12-10 18:31 ` [PATCH v3 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM Bhagavathi Perumal S
2018-12-11 3:27 ` Rob Herring
2018-12-10 18:31 ` [PATCH v3 3/3] ath10k: Add support to configure BB timing over wmi Bhagavathi Perumal S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210232523.GA14192@bogus \
--to=robh@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).