From: Kalle Valo <kvalo@codeaurora.org>
To: Stijn Tintel <stijn@linux-ipv6.be>
Cc: linux-wireless@vger.kernel.org, arend.vanspriel@broadcom.com,
Stable <stable@vger.kernel.org>,
Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH wireless-drivers] brcmfmac: fix roamoff=1 modparam
Date: Thu, 13 Dec 2018 13:46:05 +0000 (UTC) [thread overview]
Message-ID: <20181213134605.5F09D60312@smtp.codeaurora.org> (raw)
In-Reply-To: <20181204182905.32267-1-stijn@linux-ipv6.be>
Stijn Tintel <stijn@linux-ipv6.be> wrote:
> When the update_connect_param callback is set, nl80211 expects the flag
> WIPHY_FLAG_SUPPORTS_FW_ROAM to be set as well. However, this flag is
> only set when modparam roamoff=0, while the callback is set
> unconditionally. Since commit 7f9a3e150ec7 this causes a warning in
> wiphy_register, which breaks brcmfmac.
>
> Disable the update_connect_param callback when roamoff=0 to fix this.
>
> Fixes: 7f9a3e150ec7 ("nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS")
> Cc: Stable <stable@vger.kernel.org> # 4.19+
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Should this go to 4.20? Arend?
--
https://patchwork.kernel.org/patch/10712383/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-12-13 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 18:29 [PATCH wireless-drivers] brcmfmac: fix roamoff=1 modparam Stijn Tintel
2018-12-13 13:46 ` Kalle Valo [this message]
2018-12-13 16:03 ` Kalle Valo
2018-12-20 6:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213134605.5F09D60312@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stijn@linux-ipv6.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).