From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org,
Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Xinming Hu <huxinming820@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mwifiex: debugfs: correct histogram spacing, formatting
Date: Thu, 13 Dec 2018 14:54:53 +0000 (UTC) [thread overview]
Message-ID: <20181213145453.383AD601D7@smtp.codeaurora.org> (raw)
In-Reply-To: <20181203222654.GA155572@google.com>
Brian Norris <briannorris@chromium.org> wrote:
> Currently, snippets of this file look like:
>
> rx rates (in Mbps): 0=1M 1=2M2=5.5M 3=11M 4=6M 5=9M 6=12M
> 7=18M 8=24M 9=36M 10=48M 11=54M12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)
> 44-53=MCS0-9(VHT:BW20)54-63=MCS0-9(VHT:BW40)64-73=MCS0-9(VHT:BW80)
> ...
> noise_flr[--96dBm] = 22
> noise_flr[--95dBm] = 149
> noise_flr[--94dBm] = 9
> noise_flr[--93dBm] = 2
>
> We're missing some spaces, and we're adding a minus sign ('-') on values
> that are already negative signed integers.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
4cb777c64e03 mwifiex: debugfs: correct histogram spacing, formatting
--
https://patchwork.kernel.org/patch/10710795/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-12-13 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 22:53 [PATCH 1/3] mwifiex: debugfs: correct histogram spacing, formatting Brian Norris
2018-11-30 22:53 ` [PATCH 2/3] mwifiex: refactor mwifiex_parse_htinfo() for reuse Brian Norris
2018-11-30 22:53 ` [PATCH 3/3] mwifiex: add NL80211_STA_INFO_RX_BITRATE support Brian Norris
2018-12-03 18:32 ` [PATCH 1/3] mwifiex: debugfs: correct histogram spacing, formatting Joe Perches
2018-12-03 22:26 ` [PATCH v2] " Brian Norris
2018-12-04 6:37 ` Kalle Valo
2018-12-07 0:15 ` Brian Norris
2018-12-13 14:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213145453.383AD601D7@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).