From: Tony Lindgren <tony@atomide.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>, Eyal Reizer <eyalr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>, Guy Mishol <guym@ti.com>,
linux-wireless@vger.kernel.org,
linux-omap <linux-omap@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Ricardo Salveti <rsalveti@rsalveti.net>
Subject: Re: [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly
Date: Tue, 18 Dec 2018 07:54:39 -0800 [thread overview]
Message-ID: <20181218155439.GB6707@atomide.com> (raw)
In-Reply-To: <CAPDyKFoLnNWsBfaUwqwL31J=zb0UOQjXUKi7Sj0AUsnNoC6bYg@mail.gmail.com>
Hi,
* Ulf Hansson <ulf.hansson@linaro.org> [181218 12:34]:
> Instead, it looks like what you need, is a way to keep track of
> whether the SDIO card, became power cycled or if it stayed powered on,
> when "ifconfig wlan0 up" is done. In case of a power cycle, you need
> to re-program the firmware, right?
Yeah mostly. But we also need to ensure things do get powered down
properly after ifconfig wlan0 down :) IMO after ifconfig wlan0 down
returns, there should be no waiting needed.
> Would it be possible to re-program the firmware, even if the SDIO card
> stayed powered-on?
That might help for some cases, but the problem of how to ensure the
card is powered down after ifconfig wlan0 down returns still exists.
> In regards to delays needed due to a capacitance. If that really is
> the case, that shall be the managed by the mmc core, as it's there the
> power cycle sequence is being done. As a matter of fact, you should be
> able to use drivers/mmc/core/pwrseq_simple.c and extend
> "power-off-delay-us" in the DTB for Hikey if that is needed.
Hmm I do have a mostly done wlcore pwrseq driver here somewhere that
I have not had a chance to finish again. But that's not going to work
for a fix and needs updating of the related dts files too.
Regards,
Tony
next prev parent reply other threads:[~2018-12-18 15:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 16:42 [PATCH] wlcore: Fix bringing up wlan0 again if powered down briefly Tony Lindgren
2018-12-18 1:06 ` Ricardo Salveti
2018-12-18 12:34 ` Ulf Hansson
2018-12-18 15:54 ` Tony Lindgren [this message]
2018-12-20 10:14 ` Ulf Hansson
2018-12-20 23:14 ` Tony Lindgren
2018-12-23 7:38 ` [EXTERNAL] " Reizer, Eyal
2018-12-23 16:02 ` Tony Lindgren
2018-12-28 11:01 ` Ulf Hansson
2018-12-28 19:59 ` Tony Lindgren
2019-01-02 12:01 ` Ulf Hansson
2019-01-07 15:18 ` Tony Lindgren
2019-01-07 16:12 ` Kalle Valo
2019-01-14 13:47 ` Ulf Hansson
2018-12-28 9:48 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218155439.GB6707@atomide.com \
--to=tony@atomide.com \
--cc=anders.roxell@linaro.org \
--cc=eyalr@ti.com \
--cc=guym@ti.com \
--cc=john.stultz@linaro.org \
--cc=kishon@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalveti@rsalveti.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).