* [PATCH] iwlwifi: add missing break / fall-through in switch cases
@ 2018-12-19 8:30 Emmanuel Grumbach
2018-12-19 9:27 ` Grumbach, Emmanuel
0 siblings, 1 reply; 2+ messages in thread
From: Emmanuel Grumbach @ 2018-12-19 8:30 UTC (permalink / raw)
To: linux-wireless; +Cc: sara.sharon, sfr, kvalo, Emmanuel Grumbach
Two switch cases that were added recently missed break
statement and explicit fall-through. Fix this.
Fixes: f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 5 +++++
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
index bc1e4d4bb42d..b05fe75394fa 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
@@ -196,11 +196,16 @@ static int iwl_parse_fw_dbg_tlv(struct iwl_trans *trans, const u8 *data,
switch (tlv_type) {
case IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_HCMD:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_REGIONS:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_TRIGGERS:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_DEBUG_FLOW:
iwl_fw_dbg_copy_tlv(trans, tlv, true);
+ break;
default:
WARN_ONCE(1, "Invalid TLV %x\n", tlv_type);
break;
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index a65ba955783d..db95cb81c67d 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -1091,12 +1091,17 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
break;
}
case IWL_UCODE_TLV_TYPE_BUFFER_ALLOCATION:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_HCMD:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_REGIONS:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_TRIGGERS:
+ /* fall-through */
case IWL_UCODE_TLV_TYPE_DEBUG_FLOW:
if (iwlwifi_mod_params.enable_ini)
iwl_fw_dbg_copy_tlv(drv->trans, tlv, false);
+ break;
default:
IWL_DEBUG_INFO(drv, "unknown TLV: %d\n", tlv_type);
break;
--
2.14.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] iwlwifi: add missing break / fall-through in switch cases
2018-12-19 8:30 [PATCH] iwlwifi: add missing break / fall-through in switch cases Emmanuel Grumbach
@ 2018-12-19 9:27 ` Grumbach, Emmanuel
0 siblings, 0 replies; 2+ messages in thread
From: Grumbach, Emmanuel @ 2018-12-19 9:27 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org
Cc: Sharon, Sara, sfr@canb.auug.org.au, kvalo@codeaurora.org
> Subject: [PATCH] iwlwifi: add missing break / fall-through in switch cases
>
> Two switch cases that were added recently missed break statement and
> explicit fall-through. Fix this.
>
> Fixes: f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
Please drop this. We have another patch that fixes the problems and adds less noise.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-19 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 8:30 [PATCH] iwlwifi: add missing break / fall-through in switch cases Emmanuel Grumbach
2018-12-19 9:27 ` Grumbach, Emmanuel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).