* [PATCH] brcmfmac: Fix access point mode
@ 2018-12-12 19:20 Stefan Wahren
2018-12-15 11:06 ` Arend Van Spriel
2018-12-20 6:49 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Wahren @ 2018-12-12 19:20 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng
Cc: Kalle Valo, Rafał Miłecki, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev, Stefan Wahren
Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
hostapd (device_ap_sme=1 use_monitor=0):
brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
So add the missing mgmt_stypes for AP mode to fix this.
Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 7f0a5ba..05bd818 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6309,6 +6309,16 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
.tx = 0xffff,
.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
+ },
+ [NL80211_IFTYPE_AP] = {
+ .tx = 0xffff,
+ .rx = BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) |
+ BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) |
+ BIT(IEEE80211_STYPE_PROBE_REQ >> 4) |
+ BIT(IEEE80211_STYPE_DISASSOC >> 4) |
+ BIT(IEEE80211_STYPE_AUTH >> 4) |
+ BIT(IEEE80211_STYPE_DEAUTH >> 4) |
+ BIT(IEEE80211_STYPE_ACTION >> 4)
}
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] brcmfmac: Fix access point mode
2018-12-12 19:20 [PATCH] brcmfmac: Fix access point mode Stefan Wahren
@ 2018-12-15 11:06 ` Arend Van Spriel
2018-12-20 6:49 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend Van Spriel @ 2018-12-15 11:06 UTC (permalink / raw)
To: Stefan Wahren, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng
Cc: Kalle Valo, Rafał Miłecki, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev
On 12/12/2018 8:20 PM, Stefan Wahren wrote:
> Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
> hostapd (device_ap_sme=1 use_monitor=0):
>
> brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
>
> So add the missing mgmt_stypes for AP mode to fix this.
>
> Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Thanks for submitting this patch.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 7f0a5ba..05bd818 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6309,6 +6309,16 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
> .tx = 0xffff,
> .rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
> + },
> + [NL80211_IFTYPE_AP] = {
> + .tx = 0xffff,
> + .rx = BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) |
> + BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) |
> + BIT(IEEE80211_STYPE_PROBE_REQ >> 4) |
> + BIT(IEEE80211_STYPE_DISASSOC >> 4) |
> + BIT(IEEE80211_STYPE_AUTH >> 4) |
> + BIT(IEEE80211_STYPE_DEAUTH >> 4) |
> + BIT(IEEE80211_STYPE_ACTION >> 4)
> }
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] brcmfmac: Fix access point mode
2018-12-12 19:20 [PATCH] brcmfmac: Fix access point mode Stefan Wahren
2018-12-15 11:06 ` Arend Van Spriel
@ 2018-12-20 6:49 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-12-20 6:49 UTC (permalink / raw)
To: Stefan Wahren
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, Rafał Miłecki, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, netdev, Stefan Wahren
Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
> hostapd (device_ap_sme=1 use_monitor=0):
>
> brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
>
> So add the missing mgmt_stypes for AP mode to fix this.
>
> Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.
861cb5eb467f brcmfmac: Fix access point mode
--
https://patchwork.kernel.org/patch/10726965/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-20 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12 19:20 [PATCH] brcmfmac: Fix access point mode Stefan Wahren
2018-12-15 11:06 ` Arend Van Spriel
2018-12-20 6:49 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).