From: Kalle Valo <kvalo@codeaurora.org>
To: Sathishkumar Muruganandam <murugana@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Sathishkumar Muruganandam <murugana@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: Disable 4addr source port learning in 10.4 FW by default
Date: Thu, 20 Dec 2018 17:01:55 +0000 (UTC) [thread overview]
Message-ID: <20181220170155.1F321606CF@smtp.codeaurora.org> (raw)
In-Reply-To: <20181112064008.3610-1-murugana@codeaurora.org>
Sathishkumar Muruganandam <murugana@codeaurora.org> wrote:
> Currently in 10.4 FW, all the received 4addr frames are processed for
> source port learning which is enabled by default. This learning can't be
> disabled by default in FW since it breaks backward compatibility.
>
> Since ath10k uses mac80211 based 4addr mode, source port learning done in
> 10.4 FW is redundant and also causes issues when 3addr frames are
> transmitted/received for a 4addr station.
>
> One such visible functional impact is when GTK rekey frame from
> hostapd based AP to 4addr STA is dropped in AP's 10.4 FW. This is since
> GTK rekey EAPOL frame is 3addr frame on AP interface and STA enabled
> with 4addr is already allowed for receiving 3addr EAPOL frames.
>
> Source port learning implementation in 10.4 FW drops this 3addr GTK rekey
> frame in AP destinated for 4addr STA causing disassociation and
> re-association for every GTK rekey session. GTK rekey issue is not seen
> when learning is disabled in FW.
>
> To prevent such issues without breaking backward compatibility, FW
> advertises new service bit making the source port learning configurable and
> this learning is being currently disabled during ath10k vdev creation.
>
> * Tested HW: QCA9984
> * Tested FW: 10.4-3.6.0.1-00004
>
> Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
68c295f21abc ath10k: disable 4addr source port learning in 10.4 FW by default
--
https://patchwork.kernel.org/patch/10678191/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-12-20 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 6:40 [PATCH v2] ath10k: Disable 4addr source port learning in 10.4 FW by default Sathishkumar Muruganandam
2018-12-20 17:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220170155.1F321606CF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=murugana@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).