* Re: [PATCH] ath10k: remove an unnecessary NULL check [not found] <20181129103214.5tudci6izlfaasqx@kili.mountain> @ 2018-11-29 13:51 ` Kalle Valo 2018-11-29 14:21 ` Dan Carpenter 2018-11-29 14:24 ` Dan Carpenter 1 sibling, 1 reply; 4+ messages in thread From: Kalle Valo @ 2018-11-29 13:51 UTC (permalink / raw) To: Dan Carpenter; +Cc: Rakesh Pillai, ath10k, kernel-janitors, linux-wireless Dan Carpenter <dan.carpenter@oracle.com> writes: > The "survey" pointer is the address of an array element. We know that > it can't be NULL so this check can be removed. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/wireless/ath/ath10k/wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > index 659513bf4ddc..6a04727b63ce 100644 > --- a/drivers/net/wireless/ath/ath10k/wmi.c > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar, > > survey = &ar->survey[idx]; > > - if (!params->mac_clk_mhz || !survey) > + if (!params->mac_clk_mhz) > return; Can you please CC linux-wireless so that patchwork sees this? -- Kalle Valo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: remove an unnecessary NULL check 2018-11-29 13:51 ` [PATCH] ath10k: remove an unnecessary NULL check Kalle Valo @ 2018-11-29 14:21 ` Dan Carpenter 0 siblings, 0 replies; 4+ messages in thread From: Dan Carpenter @ 2018-11-29 14:21 UTC (permalink / raw) To: Kalle Valo; +Cc: Rakesh Pillai, ath10k, kernel-janitors, linux-wireless On Thu, Nov 29, 2018 at 03:51:24PM +0200, Kalle Valo wrote: > Dan Carpenter <dan.carpenter@oracle.com> writes: > > > The "survey" pointer is the address of an array element. We know that > > it can't be NULL so this check can be removed. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > --- > > drivers/net/wireless/ath/ath10k/wmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > > index 659513bf4ddc..6a04727b63ce 100644 > > --- a/drivers/net/wireless/ath/ath10k/wmi.c > > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > > @@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar, > > > > survey = &ar->survey[idx]; > > > > - if (!params->mac_clk_mhz || !survey) > > + if (!params->mac_clk_mhz) > > return; > > Can you please CC linux-wireless so that patchwork sees this? > Sure. I can resend. regards, dan carpenter ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ath10k: remove an unnecessary NULL check [not found] <20181129103214.5tudci6izlfaasqx@kili.mountain> 2018-11-29 13:51 ` [PATCH] ath10k: remove an unnecessary NULL check Kalle Valo @ 2018-11-29 14:24 ` Dan Carpenter 2018-12-20 17:07 ` Kalle Valo 1 sibling, 1 reply; 4+ messages in thread From: Dan Carpenter @ 2018-11-29 14:24 UTC (permalink / raw) To: Kalle Valo, Rakesh Pillai; +Cc: ath10k, kernel-janitors, linux-wireless The "survey" pointer is the address of an array element. We know that it can't be NULL so this check can be removed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Resending with linux-wireless Cc for patchwork. drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 659513bf4ddc..6a04727b63ce 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar, survey = &ar->survey[idx]; - if (!params->mac_clk_mhz || !survey) + if (!params->mac_clk_mhz) return; memset(survey, 0, sizeof(*survey)); -- 2.11.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: remove an unnecessary NULL check 2018-11-29 14:24 ` Dan Carpenter @ 2018-12-20 17:07 ` Kalle Valo 0 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2018-12-20 17:07 UTC (permalink / raw) To: Dan Carpenter; +Cc: Rakesh Pillai, ath10k, kernel-janitors, linux-wireless Dan Carpenter <dan.carpenter@oracle.com> wrote: > The "survey" pointer is the address of an array element. We know that > it can't be NULL so this check can be removed. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 27120f2ac995 ath10k: remove an unnecessary NULL check -- https://patchwork.kernel.org/patch/10704625/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-20 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181129103214.5tudci6izlfaasqx@kili.mountain>
2018-11-29 13:51 ` [PATCH] ath10k: remove an unnecessary NULL check Kalle Valo
2018-11-29 14:21 ` Dan Carpenter
2018-11-29 14:24 ` Dan Carpenter
2018-12-20 17:07 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).