From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Tomislav Požega" <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
hauke@hauke-m.de, nbd@nbd.name, john@phrozen.org,
daniel@makrotopia.org, John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 2/2] rt2x00: define RF5592 in init_eeprom routine
Date: Wed, 2 Jan 2019 09:37:29 +0100 [thread overview]
Message-ID: <20190102083728.GB5300@redhat.com> (raw)
In-Reply-To: <1545919526-4074-2-git-send-email-pozega.tomislav@gmail.com>
On Thu, Dec 27, 2018 at 03:05:26PM +0100, Tomislav Požega wrote:
> This patch fixes following crash on Linksys EA2750 during 5GHz wifi
> init:
>
> [ 7.955153] rt2800pci 0000:01:00.0: card - bus=0x1, slot = 0x0 irq=4
> [ 7.962259] rt2800pci 0000:01:00.0: loaded eeprom from mtd device "Factory"
> [ 7.969435] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 5592, rev 0222 detected
> [ 7.977348] ieee80211 phy0: rt2800_init_eeprom: Error - Invalid RF chipset 0x0000 detected
> [ 7.985793] ieee80211 phy0: rt2x00lib_probe_dev: Error - Failed to allocate device
> [ 7.993569] CPU 0 Unable to handle kernel paging request at virtual address 00000024, epc == 800c8f54, ra == 80249ff8
> [ 8.004408] Oops[#1]:
>
> Signed-off-by: Tomislav Požega <pozega.tomislav@gmail.com>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 7f813f6..86770e8 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -8839,6 +8839,8 @@ static int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> rf = RF3322;
> else if (rt2x00_rt(rt2x00dev, RT5350))
> rf = RF5350;
> + else if (rt2x00_rt(rt2x00dev, RT5592))
> + rf = RF5592;
This looks like workaround for the crash and AFICT it is not needed
on upstream code. This most likely is a issue with below openwrt patch:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/604-rt2x00-load-eeprom-on-SoC-from-a-mtd-device-defines-.patch;h=a98b49c541f5f76e73751c2fd2e5b85559854b87;hb=HEAD
which for some unknown reason set:
rt2x00dev->eeprom_file = &mtd_fw;
which then crash on rt2x00lib_free_eeprom_file() -> release_firmware();
Regards
Stanislaw
next prev parent reply other threads:[~2019-01-02 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 14:05 [PATCH 1/2] rt2x00: reduce tx power to nominal level on RT6352 Tomislav Požega
2018-12-27 14:05 ` [PATCH 2/2] rt2x00: define RF5592 in init_eeprom routine Tomislav Požega
2019-01-02 8:37 ` Stanislaw Gruszka [this message]
2020-07-06 11:14 ` Sebastian Gottschall
2019-02-01 12:05 ` [PATCH 1/2] rt2x00: reduce tx power to nominal level on RT6352 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102083728.GB5300@redhat.com \
--to=sgruszka@redhat.com \
--cc=blogic@openwrt.org \
--cc=daniel@makrotopia.org \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).