From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, rosenp@gmail.com
Subject: Re: [RFC 0/4] do not use sg if not properly supported by usb controller
Date: Tue, 15 Jan 2019 16:35:47 +0100 [thread overview]
Message-ID: <20190115153546.GA8387@redhat.com> (raw)
In-Reply-To: <cover.1547549771.git.lorenzo.bianconi@redhat.com>
On Tue, Jan 15, 2019 at 01:33:41PM +0100, Lorenzo Bianconi wrote:
> Use linear fragment and not a single usb scatter-gather buffer in mt76u
> {tx,rx} datapath if the usb controller has sg data length constraints.
> Moreover add disable_usb_sg module parameter in order to explicitly
> disable scatter-gather. Some users have reported sg issues on AMD IOMMU
Not sure what is the problem , but this patch set look like a workaround
not fix. If this an issue with IOMMU and sg, seems there is something wrong
in sg page mappings eigher on mt76 dirver or IOMMU driver.
If things need to be fixed in mt76 I whould check if page mappings for
sg are correct. Or remove sg usage from mt76_usb completly, mt76 MMIO
version do not use sg for framgments, so most likely USB don't need it
as well.
Thanks
Stanislaw
next prev parent reply other threads:[~2019-01-15 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 12:33 [RFC 0/4] do not use sg if not properly supported by usb controller Lorenzo Bianconi
2019-01-15 12:33 ` [RFC 1/4] mt76: usb: move mt76u_check_sg in usb.c Lorenzo Bianconi
2019-01-15 12:33 ` [RFC 2/4] mt76: usb: do not use sg buffer for fw upload Lorenzo Bianconi
2019-01-15 12:33 ` [RFC 3/4] mt76: usb: use a linear buffer for tx/rx datapath if sg is not supported Lorenzo Bianconi
2019-01-15 12:33 ` [RFC 4/4] mt76: usb: introduce disable_usb_sg parameter Lorenzo Bianconi
2019-01-15 15:35 ` Stanislaw Gruszka [this message]
2019-01-15 15:47 ` [RFC 0/4] do not use sg if not properly supported by usb controller Lorenzo Bianconi
2019-01-16 11:19 ` Stanislaw Gruszka
2019-01-16 11:44 ` Lorenzo Bianconi
2019-01-16 12:21 ` Stanislaw Gruszka
2019-01-16 13:40 ` Lorenzo Bianconi
2019-01-16 14:39 ` Stanislaw Gruszka
2019-01-16 17:16 ` Lorenzo Bianconi
2019-01-16 17:40 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115153546.GA8387@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).