From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay.Kathat@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
johannes@sipsolutions.net, Adham.Abozaeid@microchip.com
Subject: Re: [PATCH 00/13] staging: wilc1000: address few mainline review
Date: Fri, 18 Jan 2019 10:41:27 +0100 [thread overview]
Message-ID: <20190118094127.GA31389@kroah.com> (raw)
In-Reply-To: <1547731250-18518-1-git-send-email-ajay.kathat@microchip.com>
On Thu, Jan 17, 2019 at 01:21:06PM +0000, Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> This series contains changes to address few of the review comments[1].
> It mainly has the modification to remove the use of scan shadow
> buffer, make use of kernel provided API, avoid typedef's and few
> changes to simplify the logic.
>
> [1]. https://www.spinics.net/lists/linux-wireless/msg178735.html
> https://www.spinics.net/lists/linux-wireless/msg179533.html
> https://www.spinics.net/lists/linux-wireless/msg178760.html
>
> Ajay Singh (13):
> staging: wilc1000: make use of get_unaligned_le16/le32 to pack data
> staging: wilc1000: refactor wilc_wlan_set_bssid()
> staging: wilc1000: use 'struct' to pack cfg header frame in
> wilc_wlan_cfg_commit()
> staging: wilc1000: remove the use of scan shadow buffer
> staging: wilc1000: make use of cfg80211_inform_bss_frame()
> staging: wilc1000: corrected order to pack join param buffer
> staging: wilc1000: use struct to pack join parameters for FW
> staging: wilc1000: rename hidden_network related data structure
> staging: wilc1000: use single struct for 'connect' related parameters
> staging: wilc1000: refactor information message parsing logic
> staging: wilc1000: remove 'disconnect_info' structure
> staging: wilc1000: refactor handle_set_mcast_filter()
> staging: wilc1000: avoid the use of typedef for function pointers
>
> drivers/staging/wilc1000/host_interface.c | 979 +++++++---------------
> drivers/staging/wilc1000/host_interface.h | 127 +--
> drivers/staging/wilc1000/linux_wlan.c | 12 +-
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 450 ++--------
> drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +-
> drivers/staging/wilc1000/wilc_wlan.c | 35 +-
> drivers/staging/wilc1000/wilc_wlan.h | 19 +-
> drivers/staging/wilc1000/wilc_wlan_cfg.c | 27 +-
> drivers/staging/wilc1000/wilc_wlan_if.h | 3 -
> 9 files changed, 456 insertions(+), 1201 deletions(-)
Nice set of cleanups!
all applied, thanks.
greg k-h
prev parent reply other threads:[~2019-01-18 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 13:21 [PATCH 00/13] staging: wilc1000: address few mainline review Ajay.Kathat
2019-01-17 13:21 ` [PATCH 01/13] staging: wilc1000: make use of get_unaligned_le16/le32 to pack data Ajay.Kathat
2019-01-21 13:14 ` Dan Carpenter
2019-01-17 13:21 ` [PATCH 02/13] staging: wilc1000: refactor wilc_wlan_set_bssid() Ajay.Kathat
2019-01-17 13:21 ` [PATCH 03/13] staging: wilc1000: use 'struct' to pack cfg header frame in wilc_wlan_cfg_commit() Ajay.Kathat
2019-01-17 13:21 ` [PATCH 04/13] staging: wilc1000: remove the use of scan shadow buffer Ajay.Kathat
2019-01-17 13:21 ` [PATCH 05/13] staging: wilc1000: make use of cfg80211_inform_bss_frame() Ajay.Kathat
2019-01-17 13:21 ` [PATCH 06/13] staging: wilc1000: corrected order to pack join param buffer Ajay.Kathat
2019-01-17 13:21 ` [PATCH 07/13] staging: wilc1000: use struct to pack join parameters for FW Ajay.Kathat
2019-01-17 13:21 ` [PATCH 08/13] staging: wilc1000: rename hidden_network related data structure Ajay.Kathat
2019-01-17 13:21 ` [PATCH 09/13] staging: wilc1000: use single struct for 'connect' related parameters Ajay.Kathat
2019-01-17 13:21 ` [PATCH 10/13] staging: wilc1000: refactor information message parsing logic Ajay.Kathat
2019-01-17 13:21 ` [PATCH 11/13] staging: wilc1000: remove 'disconnect_info' structure Ajay.Kathat
2019-01-17 13:21 ` [PATCH 12/13] staging: wilc1000: refactor handle_set_mcast_filter() Ajay.Kathat
2019-01-17 13:21 ` [PATCH 13/13] staging: wilc1000: avoid the use of typedef for function pointers Ajay.Kathat
2019-01-18 9:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118094127.GA31389@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).