From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-kernel@vger.kernel.org,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com
Subject: Re: [PATCH] brcm80211: no need to check return value of debugfs_create functions
Date: Tue, 22 Jan 2019 21:43:40 +0100 [thread overview]
Message-ID: <20190122204340.GA30535@kroah.com> (raw)
In-Reply-To: <530d2424-d679-c81a-9d11-02b2d7631bea@broadcom.com>
On Tue, Jan 22, 2019 at 09:07:48PM +0100, Arend Van Spriel wrote:
> The prefix should be 'brcmsmac'.
>
> On 1/22/2019 4:21 PM, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
> I could argue that if above is true it would be better to make the debugfs
> function return void, but I won't ;-p
I would really want to do that, but sometimes you need that return value
to pass to other debugfs functions :(
> In start_creating() the parent dentry is indeed checked for IS_ERR() so...
>
> Acked-by: Arend van Spriel
thanks for the review!
greg k-h
next prev parent reply other threads:[~2019-01-22 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] brcm80211: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 20:07 ` Arend Van Spriel
2019-01-22 20:43 ` Greg Kroah-Hartman [this message]
2019-01-23 5:11 ` Kalle Valo
2019-02-01 12:38 ` [PATCH] brcmsmac: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122204340.GA30535@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).