* [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on
@ 2019-01-24 8:28 Jan Kiszka
2019-01-24 15:29 ` Tony Lindgren
2019-01-25 12:38 ` Michal Simek
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2019-01-24 8:28 UTC (permalink / raw)
To: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu
Cc: Ryan Grachek, John Stultz, linux-wireless, Reizer, Eyal,
Valentin Schneider, Ulf Hansson, Kalle Valo, Tony Lindgren,
Michal Simek
From: Jan Kiszka <jan.kiszka@siemens.com>
Somewhere along recent changes to power control of the wl1831, power-on
became very unreliable on the Ultra96, failing like this:
wl1271_sdio: probe of mmc2:0001:1 failed with error -16
wl1271_sdio: probe of mmc2:0001:2 failed with error -16
After playing with some dt parameters and comparing to other users of
this chip, it turned out we need some power-on delay to make things
stable again. In contrast to those other users which define 200 ms,
Ultra96 is already happy with 10 ms.
Fixes: 5869ba0653b9 ("arm64: zynqmp: Add support for Xilinx zcu100-revC")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
---
Changes in v2:
- fix changelog
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index 13a0a028df98..e5699d0d91e4 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -101,6 +101,7 @@
sdio_pwrseq: sdio-pwrseq {
compatible = "mmc-pwrseq-simple";
reset-gpios = <&gpio 7 GPIO_ACTIVE_LOW>; /* WIFI_EN */
+ post-power-on-delay-ms = <10>;
};
};
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on
2019-01-24 8:28 [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on Jan Kiszka
@ 2019-01-24 15:29 ` Tony Lindgren
2019-01-25 12:38 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2019-01-24 15:29 UTC (permalink / raw)
To: Jan Kiszka
Cc: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu, Ryan Grachek,
John Stultz, linux-wireless, Reizer, Eyal, Valentin Schneider,
Ulf Hansson, Kalle Valo, Michal Simek
* Jan Kiszka <jan.kiszka@web.de> [190124 08:29]:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Somewhere along recent changes to power control of the wl1831, power-on
> became very unreliable on the Ultra96, failing like this:
>
> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>
> After playing with some dt parameters and comparing to other users of
> this chip, it turned out we need some power-on delay to make things
> stable again. In contrast to those other users which define 200 ms,
> Ultra96 is already happy with 10 ms.
Good to hear this got sorted out, thanks everybody.
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on
2019-01-24 8:28 [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on Jan Kiszka
2019-01-24 15:29 ` Tony Lindgren
@ 2019-01-25 12:38 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2019-01-25 12:38 UTC (permalink / raw)
To: Jan Kiszka, Linux Kernel Mailing List, linux-arm-kernel, Wei Xu
Cc: Ryan Grachek, John Stultz, linux-wireless, Reizer, Eyal,
Valentin Schneider, Ulf Hansson, Kalle Valo, Tony Lindgren,
Michal Simek
On 24. 01. 19 9:28, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Somewhere along recent changes to power control of the wl1831, power-on
> became very unreliable on the Ultra96, failing like this:
>
> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>
> After playing with some dt parameters and comparing to other users of
> this chip, it turned out we need some power-on delay to make things
> stable again. In contrast to those other users which define 200 ms,
> Ultra96 is already happy with 10 ms.
>
> Fixes: 5869ba0653b9 ("arm64: zynqmp: Add support for Xilinx zcu100-revC")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
> - fix changelog
>
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index 13a0a028df98..e5699d0d91e4 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -101,6 +101,7 @@
> sdio_pwrseq: sdio-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpio 7 GPIO_ACTIVE_LOW>; /* WIFI_EN */
> + post-power-on-delay-ms = <10>;
> };
> };
>
> --
> 2.16.4
>
Applied.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-25 12:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 8:28 [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on Jan Kiszka
2019-01-24 15:29 ` Tony Lindgren
2019-01-25 12:38 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).