Re: [PATCH 1/7] mt76x02: use mask for vifs

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Thu, Jan 24, 2019 at 11:20:42PM +0100, Lorenzo Bianconi wrote:
> > > > 
> > > > I guess this does not work if you add 2 vifs and then you remove the first one
> > > > (you will end up with a wrong configuration in MT_MAC_ADDR_DW{0,1}). I guess
> > > > the hw will not work well if MT_MAC_ADDR_DW{0,1} is not properly configured
> > 
> > Maybe I am missing something, but let's assume you add the interface vif0 with address
> > 00:11:22:33:44:55 (MT_MAC_ADDR_DW{0,1} will be set to 00:11:22:33:44:55) and
> > then you add vif1 with address 00:aa:bb:cc:dd:ee. If at some point you remove
> > vif0 MT_MAC_ADDR_DW{0,1} will not be properly reconfigured. The problem will
> > be more complex if you have more interfaces

Ok, so in remove_interface extra code can be added to implement that.

> Moreover if you add 2 vif, vif0 with address 00:11:22:33:44:55 and vif1 with
> address 00:aa:bb:cc:dd:ee, have you double-checked you are able to get the same
> tpt on both interfaces? In the past IIRC there were issues if we use multibss
> with completely different mac addresses

I haven't check that. But what I can tell multi vif STA does not work, if
we do not enable PROMISC on rx filter. But this is not diffrent from MMIO
version, which mark multi vif support.

Regards
Stanislaw