Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adham.Abozaeid@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	gregkh@linuxfoundation.org, johannes@sipsolutions.net,
	Ajay.Kathat@microchip.com
Subject: Re: [PATCH 1/1] staging: wilc1000: remove redundant reset of station statistics
Date: Tue, 29 Jan 2019 11:39:52 +0300	[thread overview]
Message-ID: <20190129083952.GM1795@kadam> (raw)
In-Reply-To: <20190128223111.19400-1-adham.abozaeid@microchip.com>

On Mon, Jan 28, 2019 at 10:38:20PM +0000, Adham.Abozaeid@microchip.com wrote:
> From: Adham Abozaeid <adham.abozaeid@microchip.com>
> 
> Driver sends configuration wids to reset connection statistics in the
> device, but the device already resets it when starting a new connection
> 
> Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index fbb61de20304..286685e426c1 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -342,29 +342,11 @@ static int wilc_send_connect_wid(struct wilc_vif *vif)
>  {
>  	int result = 0;
>  	struct wid wid_list[8];
                   ^^^^^^^^^^^
We could make this array smaller as well.

> -	u32 wid_cnt = 0, dummyval = 0;
> +	u32 wid_cnt = 0;

regards,
dan carpenter

  reply	other threads:[~2019-01-29  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 22:38 [PATCH 1/1] staging: wilc1000: remove redundant reset of station statistics Adham.Abozaeid
2019-01-29  8:39 ` Dan Carpenter [this message]
2019-01-29 18:40   ` Adham.Abozaeid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129083952.GM1795@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Adham.Abozaeid@microchip.com \
    --cc=Ajay.Kathat@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox