* [PATCH] cw1200: fix indentation issues
@ 2019-01-17 14:36 Colin King
2019-01-17 14:54 ` Kalle Valo
2019-02-01 12:19 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2019-01-17 14:36 UTC (permalink / raw)
To: Solomon Peachy, Kalle Valo, David S . Miller, linux-wireless,
netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are two lines that have indentation issues, fix these.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
index 30e7646d04af..b7881232499c 100644
--- a/drivers/net/wireless/st/cw1200/fwio.c
+++ b/drivers/net/wireless/st/cw1200/fwio.c
@@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
pr_err("Device is already in QUEUE mode!\n");
- ret = -EINVAL;
- goto out;
+ ret = -EINVAL;
+ goto out;
}
switch (priv->hw_type) {
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cw1200: fix indentation issues
2019-01-17 14:36 [PATCH] cw1200: fix indentation issues Colin King
@ 2019-01-17 14:54 ` Kalle Valo
2019-01-17 14:56 ` Colin Ian King
2019-02-01 12:19 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2019-01-17 14:54 UTC (permalink / raw)
To: Colin King
Cc: Solomon Peachy, David S . Miller, linux-wireless, netdev,
kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are two lines that have indentation issues, fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
> index 30e7646d04af..b7881232499c 100644
> --- a/drivers/net/wireless/st/cw1200/fwio.c
> +++ b/drivers/net/wireless/st/cw1200/fwio.c
> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
>
> if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
> pr_err("Device is already in QUEUE mode!\n");
> - ret = -EINVAL;
> - goto out;
> + ret = -EINVAL;
> + goto out;
Just out of curiosity, how do you find these?
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cw1200: fix indentation issues
2019-01-17 14:54 ` Kalle Valo
@ 2019-01-17 14:56 ` Colin Ian King
0 siblings, 0 replies; 4+ messages in thread
From: Colin Ian King @ 2019-01-17 14:56 UTC (permalink / raw)
To: Kalle Valo
Cc: Solomon Peachy, David S . Miller, linux-wireless, netdev,
kernel-janitors, linux-kernel
On 17/01/2019 14:54, Kalle Valo wrote:
> Colin King <colin.king@canonical.com> writes:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are two lines that have indentation issues, fix these.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
>> index 30e7646d04af..b7881232499c 100644
>> --- a/drivers/net/wireless/st/cw1200/fwio.c
>> +++ b/drivers/net/wireless/st/cw1200/fwio.c
>> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
>>
>> if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
>> pr_err("Device is already in QUEUE mode!\n");
>> - ret = -EINVAL;
>> - goto out;
>> + ret = -EINVAL;
>> + goto out;
>
> Just out of curiosity, how do you find these?
>
smatch, grep for "warn: inconsistent indenting"
Colin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cw1200: fix indentation issues
2019-01-17 14:36 [PATCH] cw1200: fix indentation issues Colin King
2019-01-17 14:54 ` Kalle Valo
@ 2019-02-01 12:19 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-02-01 12:19 UTC (permalink / raw)
To: Colin King
Cc: Solomon Peachy, David S . Miller, linux-wireless, netdev,
kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are two lines that have indentation issues, fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
b0535d502d18 cw1200: fix indentation issues
--
https://patchwork.kernel.org/patch/10768357/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-01 12:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-17 14:36 [PATCH] cw1200: fix indentation issues Colin King
2019-01-17 14:54 ` Kalle Valo
2019-01-17 14:56 ` Colin Ian King
2019-02-01 12:19 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).