From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70681C282D8 for ; Fri, 1 Feb 2019 12:39:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 400D520863 for ; Fri, 1 Feb 2019 12:39:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="d+AQbglZ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FuSnQ4jn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730017AbfBAMjo (ORCPT ); Fri, 1 Feb 2019 07:39:44 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57402 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbfBAMjo (ORCPT ); Fri, 1 Feb 2019 07:39:44 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 746E760867; Fri, 1 Feb 2019 12:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024783; bh=FVKpPCU+K/CAwodzvnLQLGrxPtki7bikA0rssKVSz+4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=d+AQbglZ77ixsjPYPGw7S4rLsjmcc2LqupsdmEsJlAcQEwETaw0RktpP9cUG2o+Ja CML6Y+4Enmv6XbvpMgmKIQf5TUxofJeAVgOxazmjkCABIp4Vkwd5MNTOftMV6CBpkS mlIljEeEmqLAVKirkIK4PKW9hURxHaC7AedSafOE= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 077DD6081B; Fri, 1 Feb 2019 12:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024782; bh=FVKpPCU+K/CAwodzvnLQLGrxPtki7bikA0rssKVSz+4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=FuSnQ4jnttrHy8190PaBU7BwSNGZzvbjPr+f1g6o2QkK6Aa1HXZ2WPny162r35IWX ufxIu29IWLZrEsZvANPfOz1agErnjCml+42Rc3SyXuZNZ0GFr9UE3z9WSZLDeZZksC cZkzAFJRIvbkyFAuQxI6L4jiWxY6kTS4wM2iJgrA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 077DD6081B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] libertas: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20190122152151.16139-37-gregkh@linuxfoundation.org> References: <20190122152151.16139-37-gregkh@linuxfoundation.org> To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190201123943.746E760867@smtp.codeaurora.org> Date: Fri, 1 Feb 2019 12:39:43 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Kalle Valo > Cc: libertas-dev@lists.infradead.org > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Patch applied to wireless-drivers-next.git, thanks. caac453a9be7 libertas: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/10775743/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches