From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ajay.Kathat@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, johannes@sipsolutions.net,
Adham.Abozaeid@microchip.com
Subject: Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count
Date: Mon, 4 Feb 2019 11:13:57 +0300 [thread overview]
Message-ID: <20190204081357.GC2563@kadam> (raw)
In-Reply-To: <1549134974-5545-9-git-send-email-ajay.kathat@microchip.com>
On Sat, Feb 02, 2019 at 07:17:13PM +0000, Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> The value of 'vif_num'(interface count) starts with 0, so modified the
> loop conditions to execute for all interface.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
The right thing to do is to change ->vif_num = i + 1 in
wilc_netdev_init(). That's how it was originally. Please, add a
Fixes tag.
Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-04 8:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 19:16 [PATCH 00/15] staging: wilc1000: cleanup patches & handle review comments Ajay.Kathat
2019-02-02 19:16 ` [PATCH 01/15] staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable Ajay.Kathat
2019-02-04 13:38 ` Kalle Valo
2019-02-05 2:56 ` Ajay.Kathat
2019-02-02 19:16 ` [PATCH 02/15] staging: wilc1000: remove conditional lock in wilc_wfi_deinit_mon_interface() Ajay.Kathat
2019-02-02 19:16 ` [PATCH 03/15] staging: wilc1000: remove redundant macros for radiotap Ajay.Kathat
2019-02-02 19:17 ` [PATCH 04/15] staging: wilc1000: remove unnecessary debug log messages Ajay.Kathat
2019-02-02 19:17 ` [PATCH 05/15] staging: wilc1000: rename timeout related macros Ajay.Kathat
2019-02-02 19:17 ` [PATCH 06/15] staging: wilc1000: make use of iface type to identify p2p interface Ajay.Kathat
2019-02-02 19:17 ` [PATCH 07/15] staging: wilc1000: refactor scan() cfg80211 ops callback Ajay.Kathat
2019-02-02 19:17 ` [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count Ajay.Kathat
2019-02-04 8:13 ` Dan Carpenter [this message]
2019-02-04 9:42 ` Ajay.Kathat
2019-02-04 9:47 ` Dan Carpenter
2019-02-04 11:39 ` Greg KH
2019-02-04 12:25 ` Ajay.Kathat
2019-02-02 19:17 ` [PATCH 09/15] staging: wilc1000: remove use of 'terminated_handle' static variable Ajay.Kathat
2019-02-02 19:17 ` [PATCH 10/15] staging: wilc1000: refactor linux_wlan_init_test_config() Ajay.Kathat
2019-02-02 19:17 ` [PATCH 11/15] staging: wilc1000: refactor code to use cookie information Ajay.Kathat
2019-02-02 19:17 ` [PATCH 12/15] staging: wilc1000: use random number for cookie instead of pointer Ajay.Kathat
2019-02-02 19:17 ` [PATCH 13/15] staging: wilc1000: avoid use of interface names for validation Ajay.Kathat
2019-02-02 19:17 ` [PATCH 14/15] staging: wilc1000: add check before performing operation on net_device Ajay.Kathat
2019-02-02 19:17 ` [PATCH 15/15] staging: wilc1000: remove unused struct 'add_sta_param' Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204081357.GC2563@kadam \
--to=dan.carpenter@oracle.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox