From: Brian Norris <briannorris@chromium.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Enable Factory Test Mode for WCN3990
Date: Mon, 4 Feb 2019 17:02:08 -0800 [thread overview]
Message-ID: <20190205010207.GA219734@google.com> (raw)
In-Reply-To: <1535526038-4299-1-git-send-email-pillair@codeaurora.org>
On Wed, Aug 29, 2018 at 12:30:38PM +0530, Rakesh Pillai wrote:
> The support to put WCN3990 firmware into Factory
> test mode is not present currently. The WCN3990
> firmware can operate in Factory test mode based
> on the mode it receives in the wlan enable message
> from the host driver.
>
> When the host driver is started in testmode send
> the operating mode as UTF mode, to the WCN3990
> firmware, in the wlan enable message to start the
> firmware in Factory test mode.
>
> Tested on: WCN3990
> Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath10k/ahb.c | 3 ++-
> drivers/net/wireless/ath/ath10k/core.c | 2 +-
> drivers/net/wireless/ath/ath10k/hif.h | 7 ++++---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> drivers/net/wireless/ath/ath10k/pci.c | 3 ++-
> drivers/net/wireless/ath/ath10k/sdio.c | 3 ++-
> drivers/net/wireless/ath/ath10k/snoc.c | 20 ++++++++++++++++----
> drivers/net/wireless/ath/ath10k/testmode.c | 2 +-
> drivers/net/wireless/ath/ath10k/usb.c | 3 ++-
> 9 files changed, 31 insertions(+), 14 deletions(-)
What ever happened here? I'm told this is useful, but I see no comments
and it's marked Deferred in patchwork:
https://patchwork.kernel.org/patch/10579559/
FWIW, it looks OK to me:
Reviewed-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2019-02-05 1:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:00 [PATCH] ath10k: Enable Factory Test Mode for WCN3990 Rakesh Pillai
2019-02-05 1:02 ` Brian Norris [this message]
2019-02-07 14:14 ` Kalle Valo
2019-02-08 14:16 ` Kalle Valo
[not found] ` <20190208141604.B2D266074F@smtp.codeaurora.org>
2019-02-08 14:40 ` Rakesh Pillai
2019-02-11 16:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205010207.GA219734@google.com \
--to=briannorris@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).