From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ajay.Kathat@microchip.com
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, stable@vger.kernel.org,
Adham.Abozaeid@microchip.com, johannes@sipsolutions.net
Subject: Re: [PATCH 1/9] staging: wilc1000: revert fix related to vif index
Date: Thu, 7 Feb 2019 13:02:25 +0300 [thread overview]
Message-ID: <20190207100225.GE1978@kadam> (raw)
In-Reply-To: <8952ae4a-52a9-354b-2368-76419d15e6af@microchip.com>
On Thu, Feb 07, 2019 at 09:39:54AM +0000, Ajay.Kathat@microchip.com wrote:
> Hi Dan,
>
> On 2/7/2019 1:42 PM, Dan Carpenter wrote:
> > This patch was very confusing to review...
>
> Apologies for the confusion.
>
> > From a process perspective, you really should fold patches 1 and 2
> > together. Otherwise we're re-introducing a bug.
>
> Patch 1 and Patch 2 both are required if commit 0e490657c721 ("staging:
> wilc1000: Fix problem with wrong vif index") is applied else Patch 2 is
> enough for complete fix. For the above reason, I have divided the fixes
> into 2 patches.
> Please suggest, if I should go ahead and submit this in a single patch.
> Should I put 2 'Fixes:' tag in that merge commit or only 0e490657c721
> commit is enough.
>
I always just go with the oldest one. Another option is to include
both.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-07 10:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 7:22 [PATCH 0/9] staging: wilc1000: fixes & changes for mainline review comments Ajay.Kathat
2019-02-07 7:22 ` [PATCH 1/9] staging: wilc1000: revert fix related to vif index Ajay.Kathat
2019-02-07 8:12 ` Dan Carpenter
2019-02-07 9:39 ` Ajay.Kathat
2019-02-07 10:02 ` Dan Carpenter [this message]
2019-02-07 7:22 ` [PATCH 2/9] staging: wilc1000: fix to set the correct value for 'vif_num' Ajay.Kathat
2019-02-07 8:26 ` Dan Carpenter
2019-02-07 7:22 ` [PATCH 3/9] staging: wilc1000: add 'wilc_' prefix to have proper namespace Ajay.Kathat
2019-02-07 7:22 ` [PATCH 4/9] staging: wilc1000: move macro and function prototype from wilc_wlan_if.h file Ajay.Kathat
2019-02-07 7:22 ` [PATCH 5/9] staging: wilc1000: avoid function forward declaration in wilc_sdio.c file Ajay.Kathat
2019-02-07 7:22 ` [PATCH 6/9] staging: wilc1000: added 'wilc_' prefix for function " Ajay.Kathat
2019-02-07 7:22 ` [PATCH 7/9] staging: wilc1000: rename wilc_frmw_to_linux() Ajay.Kathat
2019-02-07 7:22 ` [PATCH 8/9] staging: wilc1000: remove 'linux_' prefix in function names Ajay.Kathat
2019-02-07 7:22 ` [PATCH 9/9] staging: wilc1000: rename linux_wlan.c and linux_mon.c Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207100225.GE1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).