From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Tom Psyborg <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Randy Oostdyk <linux-kernel@oostdyk.com>,
Daniel Golle <daniel@makrotopia.org>,
Felix Fietkau <nbd@nbd.name>, Mathias Kresin <dev@kresin.me>
Subject: Re: [PATCH v2 3/3] rt2x00: do not print error when queue is full
Date: Sun, 10 Feb 2019 10:57:27 +0100 [thread overview]
Message-ID: <20190210095726.GC2913@redhat.com> (raw)
In-Reply-To: <CAKR_QVJtQdRcbRMV+WDKw=N2CxLhUSo6hE8mUME2orD6JEMAmQ@mail.gmail.com>
On Sat, Feb 09, 2019 at 01:28:32PM +0100, Tom Psyborg wrote:
> On 09/02/2019, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > On Sat, Feb 09, 2019 at 12:11:03PM +0100, Tom Psyborg wrote:
> >> Can you reproduce interface freeze with this patch if you enable debug
> >> options to print all dbg messages?
> >
> > Haven't tried that, but I expect enabling debug messages will
> > cause troubles at hardware where printk make CPU hog.
> >
> > Stanislaw
> >
>
> Take a look at my comment from 23.01.2019. on this link:
> https://bugs.openwrt.org/index.php?do=details&task_id=2018
> There might be a chance dbg printks do not cause problems.
I'm sure printk cause problems on some hardware i.e. Wt3020 .
There is hypothesis that is because kernel try to emit
messages by misconfigured 56k serial line, but who knows.
This should be debugged and fixed but I have not idea how to do this.
Another issue not related with printk is tx queue hung, when
queue is full but we do not get any TX status interrupt. This was
mitigated in my previous set that caused throughput regression and
should be now fixed by latest RFC/RTF set.
But there are other issues, that could cause troubles.
Stanislaw
next prev parent reply other threads:[~2019-02-10 9:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 15:16 [PATCH v2 1/3] rt2x00: use ratelimited variants dev_warn/dev_err Stanislaw Gruszka
2018-12-20 15:16 ` [PATCH v2 2/3] rt2x00: check number of EPROTO errors Stanislaw Gruszka
2019-01-07 12:47 ` Jeroen Roovers
2019-01-07 15:09 ` Stanislaw Gruszka
2019-01-08 9:30 ` Jeroen Roovers
2019-01-08 10:09 ` Jeroen Roovers
2019-01-08 11:04 ` Tom Psyborg
2019-01-09 6:17 ` Jeroen Roovers
2019-01-09 11:33 ` Stanislaw Gruszka
2019-01-10 7:49 ` Jeroen Roovers
2019-01-10 14:29 ` Jeroen Roovers
2019-01-16 11:11 ` Stanislaw Gruszka
2019-01-22 17:32 ` Jeroen Roovers
2019-02-12 15:02 ` Stanislaw Gruszka
2018-12-20 15:16 ` [PATCH v2 3/3] rt2x00: do not print error when queue is full Stanislaw Gruszka
2018-12-20 17:52 ` Tom Psyborg
2018-12-21 9:59 ` Stanislaw Gruszka
2018-12-22 13:12 ` Tom Psyborg
2018-12-25 22:43 ` Tom Psyborg
2018-12-27 10:32 ` Stanislaw Gruszka
2018-12-27 10:25 ` Stanislaw Gruszka
2018-12-28 0:45 ` Tom Psyborg
2019-01-02 8:19 ` Stanislaw Gruszka
2019-02-09 11:03 ` Stanislaw Gruszka
2019-02-09 11:11 ` Tom Psyborg
2019-02-09 11:56 ` Stanislaw Gruszka
2019-02-09 12:28 ` Tom Psyborg
2019-02-09 15:38 ` Daniel Golle
2019-02-09 16:29 ` Tom Psyborg
2019-02-09 17:28 ` Daniel Golle
2019-03-19 2:37 ` Tom Psyborg
2019-02-10 9:57 ` Stanislaw Gruszka [this message]
2018-12-21 11:19 ` [PATCH v2 1/3] rt2x00: use ratelimited variants dev_warn/dev_err Joe Perches
2018-12-21 11:57 ` Stanislaw Gruszka
2018-12-21 12:48 ` Joe Perches
2018-12-21 12:51 ` Stanislaw Gruszka
2019-01-29 12:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210095726.GC2913@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=linux-kernel@oostdyk.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).