From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] brcmfmac: rework bphy_err() to take struct brcmf_pub argument
Date: Tue, 19 Feb 2019 15:07:32 +0000 (UTC) [thread overview]
Message-ID: <20190219150732.82A6B60388@smtp.codeaurora.org> (raw)
In-Reply-To: <20190215144554.6860-1-zajec5@gmail.com>
Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This macro will be used in more places not just the cfg80211.c. It makes
> sense to pass some common struct to it as "struct wiphy" is mostly
> referenced in cfg80211 code only.
>
> A very common one (used above the bus abstraction layer) is struct
> brcmf_pub. Many functions already keep reference to it which will make
> using bphy_err() simpler. It should also allow extending that macro's
> logic if it's ever needed.
>
> This improves code recently added in the commit 3ef005b82e2a ("brcmfmac:
> add bphy_err() and use it in the cfg80211.c").
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Patch applied to wireless-drivers-next.git, thanks.
16e646768396 brcmfmac: rework bphy_err() to take struct brcmf_pub argument
--
https://patchwork.kernel.org/patch/10815043/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-02-19 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 14:45 [PATCH] brcmfmac: rework bphy_err() to take struct brcmf_pub argument Rafał Miłecki
2019-02-19 15:07 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219150732.82A6B60388@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox