From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
sgruszka@redhat.com, lorenzo.bianconi@redhat.com,
dan.carpenter@oracle.com
Subject: Re: [PATCH] mt76: usb: fix warning in mt76u_buf_free
Date: Thu, 21 Feb 2019 08:15:35 +0100 [thread overview]
Message-ID: <20190221071534.GA7457@lore-desk.lan> (raw)
In-Reply-To: <87bm3520bq.fsf@purkki.adurom.net>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
> lorenzo@kernel.org writes:
>
> > From: Lorenzo Bianconi <lorenzo@kernel.org>
> >
> > Fix following static checker warning in mt76u_buf_free:
> > drivers/net/wireless/mediatek/mt76/usb.c:372 mt76u_buf_free()
> > warn: address of 'urb->sg[i]' is non-NULL
> >
> > There is no need to check sg page pointer since urb->num_sgs
> > has been already validated in mt76u_fill_rx_sg
> >
> > Fixes: cb83585e1121 ("mt76: usb: fix possible memory leak in mt76u_buf_free")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> The merge window is really close, should I take this directly to
> wireless-drivers-next?
Hi Kalle,
I think this patch can go in Felix's tree for the moment since it just fixes the warning,
the intended behaviour is to run skb_free_frag()
Regards,
Lorenzo
>
> BTW, Lorenzo please add your name to SMTP From line to make threading
> cleaner:
>
> From: lorenzo@kernel.org
>
> --
> Kalle Valo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-02-21 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1550706341.git.lorenzo@kernel.org>
2019-02-20 23:57 ` [PATCH] mt76: usb: fix warning in mt76u_buf_free lorenzo
2019-02-21 5:10 ` Kalle Valo
2019-02-21 7:15 ` Lorenzo Bianconi [this message]
2019-02-26 9:41 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221071534.GA7457@lore-desk.lan \
--to=lorenzo@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox