* [bug report] libertas_tf: don't defer firmware loading until start()
@ 2019-02-21 18:29 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-02-21 18:29 UTC (permalink / raw)
To: lkundrak; +Cc: linux-wireless
Hello Lubomir Rintel,
This is a semi-automatic email about new static checker warnings.
The patch baa0280f08c7: "libertas_tf: don't defer firmware loading
until start()" from Feb 20, 2019, leads to the following Smatch
complaint:
drivers/net/wireless/marvell/libertas_tf/if_usb.c:256 if_usb_disconnect()
warn: variable dereferenced before check 'priv' (see line 254)
drivers/net/wireless/marvell/libertas_tf/if_usb.c
253
254 if_usb_reset_device(priv);
^^^^^
The patch introduces a new dereference (inside the function).
255
256 if (priv)
^^^^
Old code assumes "priv" could be NULL.
257 lbtf_remove_card(priv);
258
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-21 18:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-21 18:29 [bug report] libertas_tf: don't defer firmware loading until start() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).