From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: usb: grab rx_page_lock for legacy mode in mt76u_refill_rx
Date: Thu, 28 Feb 2019 12:37:48 +0100 [thread overview]
Message-ID: <20190228113746.GC2768@localhost.localdomain> (raw)
In-Reply-To: <20190228112445.GA6072@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
> On Thu, Feb 28, 2019 at 12:08:45PM +0100, Lorenzo Bianconi wrote:
> > Grab rx_page_lock in mt76u_refill_rx allocating rx buffer for 'legacy'
> > mode. Remove gfp from mt76u_refill_rx signature since we need to
> > use GFP_ATOMIC
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> I'm doing some cleanup/optimization work which amongs other things
> will remove rx_page_lock. Please drop this patch.
Oh, ok. IIRC we need rx_page_lock to fix this:
481bb0432414f790066205fe77226b7d1877385d. Is it still necessary?
Moreover maybe we need this patch for 5.1 since net-next is almost close, no?
@Felix: are you planning to submit other patches for 5.1?
Regards,
Lorenzo
>
> Stanislaw
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-02-28 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1551350717.git.lorenzo@kernel.org>
2019-02-28 11:08 ` [PATCH] mt76: usb: grab rx_page_lock for legacy mode in mt76u_refill_rx Lorenzo Bianconi
2019-02-28 11:24 ` Stanislaw Gruszka
2019-02-28 11:37 ` Lorenzo Bianconi [this message]
2019-02-28 11:58 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228113746.GC2768@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).