From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jakub Kicinski <kubakici@wp.pl>
Subject: Re: mediatek: duplicate usb devices
Date: Wed, 6 Mar 2019 08:50:55 +0100 [thread overview]
Message-ID: <20190306075053.GA12946@redhat.com> (raw)
In-Reply-To: <11161578-bb42-168b-1459-f22a98f5c6bb@gmail.com>
On Tue, Mar 05, 2019 at 07:33:51PM +0100, Xose Vazquez Perez wrote:
> There a three duplicate devices at:
>
> mt76/mt76x2/usb.c: { USB_DEVICE(0x0e8d, 0x7612) }, /* Alfa AWUS036ACM */
> mt76/mt76x2/usb.c: { USB_DEVICE(0x0e8d, 0x7612) }, /* Aukey USB-AC1200 */
One duplicated entry should be removed.
> mt76/mt76x0/usb.c: { USB_DEVICE(0x148f, 0x760a) }, /* TP-Link unknown */
> mt7601u/usb.c: { USB_DEVICE(0x148f, 0x760a) },
Not sure about this.
> mt76/mt76x0/usb.c: { USB_DEVICE(0x7392, 0xb711) }, /* Edimax / Elecom */
> mt76/mt76x2/usb.c: { USB_DEVICE(0x7392, 0xb711) }, /* Edimax EW 7722 UAC */
According to wikidevi we really have duplicated IDs:
https://wikidevi.com/wiki/Edimax_EW-7722UAC
https://wikidevi.com/wiki/Elecom_WDC-433SU2M
I think we can handle this by checking ASIC version from the EEPROM
or registers at the beginning of probe and exit if it does not mach.
This should assure we will load proper driver.
Stanislaw
next prev parent reply other threads:[~2019-03-06 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:33 mediatek: duplicate usb devices Xose Vazquez Perez
2019-03-06 5:14 ` Kalle Valo
2019-03-06 7:50 ` Stanislaw Gruszka [this message]
2019-03-06 9:16 ` Lorenzo Bianconi
2019-03-06 10:09 ` Lorenzo Bianconi
2019-03-06 11:03 ` Stanislaw Gruszka
2019-03-06 18:42 ` Jakub Kicinski
2019-03-07 10:21 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306075053.GA12946@redhat.com \
--to=sgruszka@redhat.com \
--cc=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).