From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Tony Chuang <yhchuang@realtek.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
"briannorris@chromium.org" <briannorris@chromium.org>
Subject: Re: [PATCH v2 00/24] rtw88: major fixes for 8822c to have stable functionalities
Date: Fri, 8 Mar 2019 14:00:21 +0100 [thread overview]
Message-ID: <20190308130021.GA4108@redhat.com> (raw)
In-Reply-To: <87a7i58xag.fsf@kamboji.qca.qualcomm.com>
On Fri, Mar 08, 2019 at 12:39:51PM +0200, Kalle Valo wrote:
> Once everyone are happy about the driver, at least it needs a review
> from Johannes and me but reviews from others is more than welcome. I
> also saw that Brian gave good comments but not sure if he thinks the
> driver is ready for upstream?
>
> An ideal schedule is to apply the driver just after the -rc1 is release,
> so within two weeks time. That way we have maximum time to fix any
> problems which might arise.
>
> Did Stanislaw already review this driver? I don't see any mentioning of
> that in the cover letter[1].
I haven't done that for v3 and later, but v2 of rtw88 was more or less
ok for me (did not see anything wrong that could not be fixed after
inclusion). Anyway, happy to do the review if it helps to merge the
driver.
Stanislaw
next prev parent reply other threads:[~2019-03-08 13:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 8:58 [PATCH v2 00/24] rtw88: major fixes for 8822c to have stable functionalities yhchuang
2019-02-14 8:58 ` [PATCH v2 01/24] rtw88: report correct tx status if mac80211 requested one yhchuang
2019-02-14 8:58 ` [PATCH v2 02/24] rtw88: add get_c2h_from_skb for extracting c2h commands yhchuang
2019-02-14 8:58 ` [PATCH v2 03/24] rtw88: can not support vif beacon filter actually yhchuang
2019-02-14 8:58 ` [PATCH v2 04/24] rtw88: fix incorrect bit definition for RF mode yhchuang
2019-02-14 8:58 ` [PATCH v2 05/24] rtw88: add a delay after writing a rf register yhchuang
2019-02-14 8:58 ` [PATCH v2 06/24] rtw88: 8822c: correct crystal setting yhchuang
2019-02-14 8:58 ` [PATCH v2 07/24] rtw88: 8822c: update efuse table as released yhchuang
2019-02-14 8:58 ` [PATCH v2 08/24] rtw88: 8822c: update pwr_seq to v12 yhchuang
2019-02-14 8:58 ` [PATCH v2 09/24] rtw88: 8822c: update phy parameter to v27 yhchuang
2019-02-14 8:58 ` [PATCH v2 10/24] rtw88: 8822c: update channel setting yhchuang
2019-02-14 8:58 ` [PATCH v2 11/24] rtw88: 8822c: update trx mode setting yhchuang
2019-02-14 8:58 ` [PATCH v2 12/24] rtw88: add module param to switch lps supportability yhchuang
2019-02-14 8:58 ` [PATCH v2 13/24] rtw88: add 8822c tx power index table parsing support yhchuang
2019-02-14 8:58 ` [PATCH v2 14/24] rtw88: add 8822c tx agc support yhchuang
2019-02-14 8:58 ` [PATCH v2 15/24] rtw88: extract utility functions into util.c yhchuang
2019-02-14 8:58 ` [PATCH v2 16/24] rtw88: 8822c: add support for DACK yhchuang
2019-02-14 8:58 ` [PATCH v2 17/24] rtw88: 8822c: fix RSC setting yhchuang
2019-02-14 8:58 ` [PATCH v2 18/24] rtw88: 8822c: set ack timeout yhchuang
2019-02-14 8:58 ` [PATCH v2 19/24] rtw88: 8822c: do not reset MAC Rx before sending CCK packet yhchuang
2019-02-14 8:58 ` [PATCH v2 20/24] rtw88: 8822c: parse packet by sigb length yhchuang
2019-02-14 8:59 ` [PATCH v2 21/24] rtw88: do not count dummy tail into rx counter yhchuang
2019-02-14 8:59 ` [PATCH v2 22/24] rtw88: set OFDM ctx to receive ack after cts2self yhchuang
2019-02-14 8:59 ` [PATCH v2 23/24] rtw88: fix slot time value yhchuang
2019-02-14 8:59 ` [PATCH v2 24/24] rtw88: 8822b: turn rtw_write32s_mask into macro yhchuang
2019-02-26 8:20 ` [PATCH v2 00/24] rtw88: major fixes for 8822c to have stable functionalities Tony Chuang
2019-03-08 10:39 ` Kalle Valo
2019-03-08 12:38 ` Tony Chuang
2019-03-08 13:06 ` Stanislaw Gruszka
2019-03-08 13:00 ` Stanislaw Gruszka [this message]
2019-03-08 18:43 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308130021.GA4108@redhat.com \
--to=sgruszka@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=briannorris@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).