Re: [PATCHv3 0/9] cfg80211/mac80211: Add support for TID specific configuration

[Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>]

Hello Tamizh,

> Add infrastructure to support per TID configurations like noack policy,
> retry count, AMPDU control(disable/enable), RTSCTS control(enable/disable)
> and TX rate mask configurations.
> This will be useful for the driver which can supports data TID
> specific configuration rather than phy level configurations.
> Here NL80211_CMD_SET_TID_CONFIG added to support this operation by
> accepting TID configuration.
> This command can accept STA mac addreess to make the configuration
> station specific rather than applying to all the connected stations
> to the netdev.
> And this nested command configuration can accept multiple number of
> data TID specific configuration in a single command,
> enum ieee80211_tid_conf_mask used to notify the driver that which
> configuration got modified for the TID.
> 
> Tamizh chelvam (9):
>   nl80211: New netlink command for TID specific configuration
>   nl80211: Add new netlink attribute for TID speicific retry count
>   nl80211: Add netlink attribute for AMPDU aggregation enable/disable
>   nl80211: Add netlink attribute to enable/disable RTS_CTS
>   nl80211: Add netlink attribute to configure TID specific tx rate
>   mac80211: Add api to support configuring TID specific configuration
>   ath10k: Add wmi command support for station specific TID config
>   ath10k: Add new api to support TID specific configuration
>   ath10k: Add extended TID configuration support
> 
> v3:
>   * Modified "nl80211: Add netlink attribute to configure TID specific tx rate" patch
>     to accept multiple TX rate configuration at a time.
>   * Modified noack and ampdu variable data type to int in
>     "mac80211: Add api to support configuring TID specific configuration" patch to store
>     default configuration.
>   * Modified "ath10k: Add new api to support TID specific configuration" patch to handle
>     default values for noack and ampdu. And added sta pointer sanity check in
>     ath10k_mac_tid_bitrate_config function.
>   * Fixed "ath10k: Add extended TID configuration support" wmi command parameters
>     assigned part.
> 
> v2:
>   * Added support to accept multiple TID configuration
>   * Added support to configure TX rate and RTSCTS control
> 
>  drivers/net/wireless/ath/ath10k/core.c    |   4 +
>  drivers/net/wireless/ath/ath10k/core.h    |   6 +
>  drivers/net/wireless/ath/ath10k/mac.c     | 679 ++++++++++++++++++++++++++----
>  drivers/net/wireless/ath/ath10k/wmi-ops.h |  19 +
>  drivers/net/wireless/ath/ath10k/wmi.c     |  35 ++
>  drivers/net/wireless/ath/ath10k/wmi.h     |  72 ++++
>  include/net/cfg80211.h                    |  57 +++
>  include/net/mac80211.h                    |  35 ++
>  include/uapi/linux/nl80211.h              | 182 ++++++++
>  net/mac80211/cfg.c                        |  28 ++
>  net/mac80211/driver-ops.h                 |  15 +
>  net/wireless/nl80211.c                    | 253 ++++++++++-
>  net/wireless/rdev-ops.h                   |  11 +
>  net/wireless/trace.h                      |  18 +
>  14 files changed, 1316 insertions(+), 98 deletions(-)

I am not familiar with ath10k driver internals. But for cfg80211/nl80211:
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>

Regards,
Sergey