From: kbuild test robot <lkp@intel.com>
To: Johannes Berg <johannes.berg@intel.com>
Cc: kbuild-all@01.org, linux-wireless@vger.kernel.org
Subject: [mac80211-next:netlink-validate-build-test-2 3/7] net/sched/act_tunnel_key.c:128:8: error: implicit declaration of function 'nla_validate'; did you mean '__nla_validate'?
Date: Sun, 24 Mar 2019 16:45:54 +0800 [thread overview]
Message-ID: <201903241653.Yri42KOh%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3948 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git netlink-validate-build-test-2
head: eefd811df5bc7a7ad129ce4ac3ff473802736ad9
commit: 1217489aab75c491228eeb01ebbceabd29e989cc [3/7] netlink: make validation more configurable for future strictness
config: i386-randconfig-i2-201912 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 1217489aab75c491228eeb01ebbceabd29e989cc
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
net/sched/act_tunnel_key.c: In function 'tunnel_key_copy_opts':
>> net/sched/act_tunnel_key.c:128:8: error: implicit declaration of function 'nla_validate'; did you mean '__nla_validate'? [-Werror=implicit-function-declaration]
err = nla_validate(head, len, TCA_TUNNEL_KEY_ENC_OPTS_MAX,
^~~~~~~~~~~~
__nla_validate
cc1: some warnings being treated as errors
vim +128 net/sched/act_tunnel_key.c
0ed5269f Simon Horman 2018-06-26 121
0ed5269f Simon Horman 2018-06-26 122 static int tunnel_key_copy_opts(const struct nlattr *nla, u8 *dst,
0ed5269f Simon Horman 2018-06-26 123 int dst_len, struct netlink_ext_ack *extack)
0ed5269f Simon Horman 2018-06-26 124 {
0ed5269f Simon Horman 2018-06-26 125 int err, rem, opt_len, len = nla_len(nla), opts_len = 0;
0ed5269f Simon Horman 2018-06-26 126 const struct nlattr *attr, *head = nla_data(nla);
0ed5269f Simon Horman 2018-06-26 127
0ed5269f Simon Horman 2018-06-26 @128 err = nla_validate(head, len, TCA_TUNNEL_KEY_ENC_OPTS_MAX,
0ed5269f Simon Horman 2018-06-26 129 enc_opts_policy, extack);
0ed5269f Simon Horman 2018-06-26 130 if (err)
0ed5269f Simon Horman 2018-06-26 131 return err;
0ed5269f Simon Horman 2018-06-26 132
0ed5269f Simon Horman 2018-06-26 133 nla_for_each_attr(attr, head, len, rem) {
0ed5269f Simon Horman 2018-06-26 134 switch (nla_type(attr)) {
0ed5269f Simon Horman 2018-06-26 135 case TCA_TUNNEL_KEY_ENC_OPTS_GENEVE:
0ed5269f Simon Horman 2018-06-26 136 opt_len = tunnel_key_copy_geneve_opt(attr, dst,
0ed5269f Simon Horman 2018-06-26 137 dst_len, extack);
0ed5269f Simon Horman 2018-06-26 138 if (opt_len < 0)
0ed5269f Simon Horman 2018-06-26 139 return opt_len;
0ed5269f Simon Horman 2018-06-26 140 opts_len += opt_len;
0ed5269f Simon Horman 2018-06-26 141 if (dst) {
0ed5269f Simon Horman 2018-06-26 142 dst_len -= opt_len;
0ed5269f Simon Horman 2018-06-26 143 dst += opt_len;
0ed5269f Simon Horman 2018-06-26 144 }
0ed5269f Simon Horman 2018-06-26 145 break;
0ed5269f Simon Horman 2018-06-26 146 }
0ed5269f Simon Horman 2018-06-26 147 }
0ed5269f Simon Horman 2018-06-26 148
0ed5269f Simon Horman 2018-06-26 149 if (!opts_len) {
0ed5269f Simon Horman 2018-06-26 150 NL_SET_ERR_MSG(extack, "Empty list of tunnel options");
0ed5269f Simon Horman 2018-06-26 151 return -EINVAL;
0ed5269f Simon Horman 2018-06-26 152 }
0ed5269f Simon Horman 2018-06-26 153
0ed5269f Simon Horman 2018-06-26 154 if (rem > 0) {
0ed5269f Simon Horman 2018-06-26 155 NL_SET_ERR_MSG(extack, "Trailing data after parsing tunnel key options attributes");
0ed5269f Simon Horman 2018-06-26 156 return -EINVAL;
0ed5269f Simon Horman 2018-06-26 157 }
0ed5269f Simon Horman 2018-06-26 158
0ed5269f Simon Horman 2018-06-26 159 return opts_len;
0ed5269f Simon Horman 2018-06-26 160 }
0ed5269f Simon Horman 2018-06-26 161
:::::: The code at line 128 was first introduced by commit
:::::: 0ed5269f9e41f495c8e9020c85f5e1644c1afc57 net/sched: add tunnel option support to act_tunnel_key
:::::: TO: Simon Horman <simon.horman@netronome.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30524 bytes --]
reply other threads:[~2019-03-24 8:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903241653.Yri42KOh%lkp@intel.com \
--to=lkp@intel.com \
--cc=johannes.berg@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox