From: Bob Copeland <me@bobcopeland.com>
To: Balaji Pothunoori <bpothuno@codeaurora.org>
Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org,
Ashok Raj Nagarajan <arnagara@codeaurora.org>
Subject: Re: [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated
Date: Tue, 2 Apr 2019 08:59:08 -0400 [thread overview]
Message-ID: <20190402125908.GD32168@localhost> (raw)
In-Reply-To: <cd497042d164c322bc06c4cfbf26435a@codeaurora.org>
On Tue, Apr 02, 2019 at 12:00:29PM +0530, Balaji Pothunoori wrote:
> > Should this really dBm? It's a bit asymmetric for WIPHY_TX_POWER_LEVEL
> > to
> > use mBm and this to use dBm, and I might want to adjust in half-dB steps
> > if
> > supported by hardware. Also allocating an s16 is a bit much for dBm.
>
> if user will send mBm value then driver has to convert to dBm because
> firmware will expect the value in dBm.
> Please refer johannes comments on following patch " [EXT] Re: [PATCH] iw:
> Add support for controlling tx power for per station"
> for the reason why we opted dBm.
The quote was:
> I would prefer if this was *dBm*, rather than mBm, and be allowed to
> take float values, i.e. this would become "limit 20".
I read that as "iw should convert fractional dBm to mBm" not "kernel should
only support dBm".
ath10k might only support dBm, fine -- but even ath5k could support
per-packet transmit power in 0.5 dB steps, so this is already limiting
applicability to existing hardware.
--
Bob Copeland %% https://bobcopeland.com/
next prev parent reply other threads:[~2019-04-02 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 10:48 [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated Balaji Pothunoori
2019-03-31 6:00 ` kbuild test robot
2019-04-01 20:46 ` Bob Copeland
2019-04-02 6:30 ` Balaji Pothunoori
2019-04-02 12:59 ` Bob Copeland [this message]
2019-04-02 13:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402125908.GD32168@localhost \
--to=me@bobcopeland.com \
--cc=arnagara@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bpothuno@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).