From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Shahar S Matityahu <shahar.s.matityahu@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 13/13] iwlwifi: dbg_ini: set dump bit only when trigger collection is certain
Date: Wed, 3 Apr 2019 12:22:24 +0300 [thread overview]
Message-ID: <20190403092224.815-14-luca@coelho.fi> (raw)
In-Reply-To: <20190403092224.815-1-luca@coelho.fi>
From: Shahar S Matityahu <shahar.s.matityahu@intel.com>
In case the the trigger occurrences is zero or force_restart is set, the
driver sets IWL_FWRT_STATUS_DUMPING without actually scheduling trigger
collection. At this point no other dump collection can be performed.
Solve this by setting IWL_FWRT_STATUS_DUMPING bit only when the driver
is surely going to schedule dump collection
Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
index 57e3f74c893c..8f34d426a4c4 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -2147,6 +2147,9 @@ int _iwl_fw_dbg_ini_collect(struct iwl_fw_runtime *fwrt,
return 0;
}
+ if (test_and_set_bit(IWL_FWRT_STATUS_DUMPING, &fwrt->status))
+ return -EBUSY;
+
fwrt->dump.ini_trig_id = id;
IWL_WARN(fwrt, "WRT: collecting data: ini trigger %d fired.\n", id);
--
2.20.1
prev parent reply other threads:[~2019-04-03 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 9:22 [PATCH 00/13] iwlwifi: updates intended for v5.2 2019-04-03 Luca Coelho
2019-04-03 9:22 ` [PATCH 01/13] iwlwifi: bump FW API to 47 for 22000 series Luca Coelho
2019-04-03 9:22 ` [PATCH 02/13] iwlwifi: mvm: set 512 TX queue slots for AX210 devices Luca Coelho
2019-04-03 9:22 ` [PATCH 03/13] iwlwifi: unite macros with same meaning Luca Coelho
2019-04-03 9:22 ` [PATCH 04/13] iwlwifi: dbg_ini: support notification and dhc regions type parsing Luca Coelho
2019-04-03 9:22 ` [PATCH 05/13] iwlwifi: add FW_INFO debug level Luca Coelho
2019-04-03 9:22 ` [PATCH 06/13] iwlwifi: dbg_ini: add debug prints to the ini flows Luca Coelho
2019-04-04 8:58 ` [PATCH v2 " Luca Coelho
2019-04-03 9:22 ` [PATCH 07/13] iwlwifi: rs: consider LDPC capability in case of HE Luca Coelho
2019-04-03 9:22 ` [PATCH 08/13] iwlwifi: dbg: add periphery memory dumping support to ax210 device family Luca Coelho
2019-04-03 9:22 ` [PATCH 09/13] iwlwifi: dbg: add lmac and umac PC registers to periphery dump Luca Coelho
2019-04-03 9:22 ` [PATCH 10/13] iwlwifi: mvm: support rtt confidence indication Luca Coelho
2019-04-03 9:22 ` [PATCH 11/13] iwlwifi: remove unused 0x40C0 PCI device IDs Luca Coelho
2019-04-03 9:22 ` [PATCH 12/13] iwlwifi: mvm: Change an 'else if' into an 'else' in iwl_mvm_send_add_bcast_sta Luca Coelho
2019-04-03 9:22 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403092224.815-14-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=shahar.s.matityahu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox