From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/2] rtlwifi: Fix duplicate tests of one of the RX descriptors
Date: Thu, 4 Apr 2019 10:24:17 +0000 (UTC) [thread overview]
Message-ID: <20190404102417.985E861D45@smtp.codeaurora.org> (raw)
In-Reply-To: <20190304215940.2608-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In drivers rtl8188ee, rtl8821ae, rtl8723be, and rtl8192ee, the reason
> for a wake-up is returned in the fourth RX descriptor in bits 29-31. Due
> to typographical errors, all but rtl8821ae test bit 31 twice and fail to
> test bit 29.
>
> This error causes no problems as the tests are only used to set bits in
> a quantity output in an optional debugging statement.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Failed to apply:
fatal: sha1 information is lacking or useless (drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c).
error: could not build fake ancestor
Applying: rtlwifi: Convert the wake_match variable to local
Patch failed at 0001 rtlwifi: Convert the wake_match variable to local
The copy of the patch that failed is found in: .git/rebase-apply/patch
2 patches set to Changes Requested.
10838677 [1/2] rtlwifi: Fix duplicate tests of one of the RX descriptors
10838679 [2/2] rtlwifi: Convert the wake_match variable to local
--
https://patchwork.kernel.org/patch/10838677/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-04-04 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 21:59 [PATCH 0/2] Modify the handling of the reason for a wakeup Larry Finger
2019-03-04 21:59 ` [PATCH 1/2] rtlwifi: Fix duplicate tests of one of the RX descriptors Larry Finger
2019-04-04 10:24 ` Kalle Valo [this message]
2019-03-04 21:59 ` [PATCH 2/2] rtlwifi: Convert the wake_match variable to local Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404102417.985E861D45@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).