From: megous@megous.com
To: linux-sunxi@googlegroups.com,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Ondrej Jirman <megous@megous.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Naveen Gupta <naveen.gupta@cypress.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org
Subject: [PATCH 02/12] drm: sun4i: Add support for enabling DDC I2C bus to dw_hdmi glue
Date: Sat, 6 Apr 2019 01:45:04 +0200 [thread overview]
Message-ID: <20190405234514.6183-3-megous@megous.com> (raw)
In-Reply-To: <20190405234514.6183-1-megous@megous.com>
From: Ondrej Jirman <megous@megous.com>
Orange Pi 3 board requires enabling DDC I2C bus via some GPIO connected
transistors, before it can be used. Model this as a power supply for DDC
(via regulator framework).
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 17 ++++++++++++++++-
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
index dc47720c99ba..a1518525fa2f 100644
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -146,16 +146,28 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master,
return PTR_ERR(hdmi->regulator);
}
+ hdmi->ddc_regulator = devm_regulator_get(dev, "ddc");
+ if (IS_ERR(hdmi->ddc_regulator)) {
+ dev_err(dev, "Couldn't get ddc regulator\n");
+ return PTR_ERR(hdmi->ddc_regulator);
+ }
+
ret = regulator_enable(hdmi->regulator);
if (ret) {
dev_err(dev, "Failed to enable regulator\n");
return ret;
}
+ ret = regulator_enable(hdmi->ddc_regulator);
+ if (ret) {
+ dev_err(dev, "Failed to enable ddc regulator\n");
+ goto err_disable_regulator;
+ }
+
ret = reset_control_deassert(hdmi->rst_ctrl);
if (ret) {
dev_err(dev, "Could not deassert ctrl reset control\n");
- goto err_disable_regulator;
+ goto err_disable_ddc_regulator;
}
ret = clk_prepare_enable(hdmi->clk_tmds);
@@ -208,6 +220,8 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master,
clk_disable_unprepare(hdmi->clk_tmds);
err_assert_ctrl_reset:
reset_control_assert(hdmi->rst_ctrl);
+err_disable_ddc_regulator:
+ regulator_disable(hdmi->ddc_regulator);
err_disable_regulator:
regulator_disable(hdmi->regulator);
@@ -223,6 +237,7 @@ static void sun8i_dw_hdmi_unbind(struct device *dev, struct device *master,
sun8i_hdmi_phy_remove(hdmi);
clk_disable_unprepare(hdmi->clk_tmds);
reset_control_assert(hdmi->rst_ctrl);
+ regulator_disable(hdmi->ddc_regulator);
regulator_disable(hdmi->regulator);
}
diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
index 720c5aa8adc1..6e93d55560b6 100644
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
@@ -188,6 +188,7 @@ struct sun8i_dw_hdmi {
struct sun8i_hdmi_phy *phy;
struct dw_hdmi_plat_data plat_data;
struct regulator *regulator;
+ struct regulator *ddc_regulator;
const struct sun8i_dw_hdmi_quirks *quirks;
struct reset_control *rst_ctrl;
};
--
2.21.0
next prev parent reply other threads:[~2019-04-05 23:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 23:45 [PATCH 00/12] Add support for Orange Pi 3 megous
2019-04-05 23:45 ` [PATCH 01/12] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS megous
2019-04-08 7:46 ` Maxime Ripard
2019-04-08 22:58 ` Ondřej Jirman
2019-04-09 7:22 ` Maxime Ripard
2019-04-05 23:45 ` megous [this message]
2019-04-08 7:23 ` [PATCH 02/12] drm: sun4i: Add support for enabling DDC I2C bus to dw_hdmi glue Maxime Ripard
2019-04-08 7:28 ` [linux-sunxi] " Chen-Yu Tsai
2019-04-08 8:47 ` Maxime Ripard
2019-04-08 12:17 ` Ondřej Jirman
2019-04-09 7:45 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 03/12] dt-bindings: display: sun4i-drm: Add DDC power supply megous
2019-04-05 23:45 ` [PATCH 04/12] arm64: dts: allwinner: orange-pi-3: Enable HDMI output megous
2019-04-08 7:24 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 05/12] net: stmmac: sun8i: add support for Allwinner H6 EMAC megous
2019-04-08 7:25 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one megous
2019-04-06 10:24 ` Sergei Shtylyov
2019-04-05 23:45 ` [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet megous
2019-04-08 6:11 ` Jagan Teki
2019-04-08 22:26 ` Ondřej Jirman
2019-04-08 7:40 ` Maxime Ripard
2019-04-08 23:22 ` Ondřej Jirman
2019-04-09 7:23 ` Maxime Ripard
2019-04-09 7:35 ` Linus Walleij
2019-04-05 23:45 ` [PATCH 08/12] arm64: dts: allwinner: h6: Add MMC1 pins megous
2019-04-08 7:43 ` Maxime Ripard
2019-04-08 22:41 ` Ondřej Jirman
2019-04-09 7:20 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 09/12] pinctrl: sunxi: Prepare for alternative bias voltage setting methods megous
2019-04-08 12:53 ` Linus Walleij
2019-04-08 13:08 ` Ondřej Jirman
2019-04-05 23:45 ` [PATCH 10/12] pinctrl: sunxi: Support I/O bias voltage setting on H6 megous
2019-04-08 1:31 ` Ondřej Jirman
2019-04-08 7:42 ` Maxime Ripard
2019-04-05 23:45 ` [PATCH 11/12] brcmfmac: Loading the correct firmware for brcm43456 megous
2019-04-13 11:06 ` Kalle Valo
2019-04-05 23:45 ` [PATCH 12/12] arm64: dts: allwinner: orange-pi-3: Enable WiFi megous
2019-04-07 15:31 ` [linux-sunxi] " Clément Péron
2019-04-07 16:15 ` Ondřej Jirman
2019-04-07 13:36 ` [linux-sunxi] [PATCH 00/12] Add support for Orange Pi 3 Clément Péron
2019-04-07 14:32 ` Ondřej Jirman
2019-04-07 15:08 ` Clément Péron
2019-04-08 6:01 ` Jagan Teki
2019-04-08 12:46 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405234514.6183-3-megous@megous.com \
--to=megous@megous.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=joabreu@synopsys.com \
--cc=kvalo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=naveen.gupta@cypress.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).