Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Subject: Re: question: crda timeout in cfg80211
Date: Tue, 9 Apr 2019 08:35:57 +0000	[thread overview]
Message-ID: <20190409083551.g27qvcxqhfm2x4uq@bars> (raw)
In-Reply-To: <07e019232f1720ce70d3353ce73cd32a23e5ed2f.camel@sipsolutions.net>

> > Linux cfg80211 regulatory subsystem uses CRDA timeout to ensure completion
> > of regulatory updates, performed by user-space software. See call_crda
> > functon in net/wireless/reg.c:
> >
> > static int call_crda(const char *alpha2)
> > {
> >       ...
> >
> >       queue_delayed_work(system_power_efficient_wq,
> >                       &crda_timeout, msecs_to_jiffies(3142));
> >       return 0;
> > }
> >
> > So regulatory update/reset operations shall be completed in 3142 msec.
> > And that includes processing of regulatory notifiers for all the
> > wireless cards in the system.
> >
> > It is not quite clear where this specific timeout value came from.
> > Original commit (a90c7a313a1c5b) doesn't go into details about it.
> >
> > Any ideas where it could come from ?
> 
> No particular reason. It's just ~pi seconds, and IIRC Luis thought that
> was funny :-)

Indeed, it is PI. I should have known. But instead I spent some time
digging through 802.11 specs :)

> Are you seeing any issues with that?
 
Well, as I mentioned in my question, regulatory update/reset operations
shall be completed in ~pi seconds for _all_ the wireless cards in the
system. In our case, regulatory reset operation may be fairly costly.
As a result, we end up with recurring reset timeout, when more than one
qtn card is installed in a single pcie host. One option for us is to
optimize regulatory reset operations in firmware.

But what do you think about converting crda_timeout into a per-wiphy
timeout in the case when all wiphy-s are being processed, e.g.
in update_all_wiphy_regulatory.

Regards,
Sergey

  reply	other threads:[~2019-04-09  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 12:42 question: crda timeout in cfg80211 Sergey Matyukevich
2019-04-08 19:06 ` Johannes Berg
2019-04-09  8:35   ` Sergey Matyukevich [this message]
2019-04-09  8:40     ` Johannes Berg
2019-04-11 12:40       ` Sergey Matyukevich
2019-04-23 12:31         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190409083551.g27qvcxqhfm2x4uq@bars \
    --to=sergey.matyukevich.os@quantenna.com \
    --cc=igor.mitsyanko.os@quantenna.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox