From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Tom Psyborg <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Daniel Golle <daniel@makrotopia.org>,
Felix Fietkau <nbd@nbd.name>, Mathias Kresin <dev@kresin.me>,
Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH 15/21] rt2x00: rt2800lib: hardcode txmixer gain values to zero for RT3883
Date: Wed, 10 Apr 2019 10:22:42 +0200 [thread overview]
Message-ID: <20190410082241.GA2538@redhat.com> (raw)
In-Reply-To: <CAKR_QVJtwmpEK2a5br2YEKPsAF0GHXwny5YbCTFoO_mgD+fVJw@mail.gmail.com>
On Tue, Apr 09, 2019 at 05:26:46PM +0200, Tom Psyborg wrote:
> On 09/04/2019, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > From: Gabor Juhos <juhosg@openwrt.org>
> >
> > Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
> > drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > index 0687bef990e1..4ea94c62d439 100644
> > --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > @@ -9128,7 +9128,8 @@ static u8 rt2800_get_txmixer_gain_24g(struct
> > rt2x00_dev *rt2x00dev)
> > {
> > u16 word;
> >
> > - if (rt2x00_rt(rt2x00dev, RT3593))
> > + if (rt2x00_rt(rt2x00dev, RT3593) ||
> > + rt2x00_rt(rt2x00dev, RT3883))
> > return 0;
> >
> > word = rt2800_eeprom_read(rt2x00dev, EEPROM_TXMIXER_GAIN_BG);
> > @@ -9142,7 +9143,8 @@ static u8 rt2800_get_txmixer_gain_5g(struct rt2x00_dev
> > *rt2x00dev)
> > {
> > u16 word;
> >
> > - if (rt2x00_rt(rt2x00dev, RT3593))
> > + if (rt2x00_rt(rt2x00dev, RT3593) ||
> > + rt2x00_rt(rt2x00dev, RT3883))
> > return 0;
> >
> > word = rt2800_eeprom_read(rt2x00dev, EEPROM_TXMIXER_GAIN_A);
> > --
> > 2.7.5
> >
> >
>
> Did someone actually verified this is correct?
I don't know if it was verified or not.
Stanislaw
next prev parent reply other threads:[~2019-04-10 8:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 11:36 [PATCH 00/21] RT3883 support from OpenWrt Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 01/21] rt2x00: rt2800lib: enable support for RT3883 Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 02/21] rt2x00: rt2800lib: add rf_vals for RF3853 Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 03/21] rt2x00: rt2800lib: enable VCO calibration " Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 04/21] rt2x00: rt2800lib: add channel configuration function " Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 05/21] rt2x00: rt2800lib: enable RF3853 support Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 06/21] rt2x00: rt2800lib: add MAC register initialization for RT3883 Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 07/21] rt2x00: rt2800soc: fix rt2800soc_disable_radio " Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 08/21] rt2x00: rt2800lib: add BBP register initialization " Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 09/21] rt2x00: rt2800lib: add RFCSR " Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 10/21] rt2x00: rt2800lib: use the extended EEPROM map " Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 11/21] rt2x00: rt2800lib: force rf type to RF3853 on RT3883 Stanislaw Gruszka
2019-04-09 11:36 ` [PATCH 12/21] rt2x00: rt2800lib: add channel configuration code for RT3883 Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 13/21] rt2x00: rt2800lib: fix txpower_to_dev function " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 14/21] rt2x00: rt2800lib: use correct txpower calculation " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 15/21] rt2x00: rt2800lib: hardcode txmixer gain values to zero " Stanislaw Gruszka
2019-04-09 15:26 ` Tom Psyborg
2019-04-10 8:22 ` Stanislaw Gruszka [this message]
2019-04-10 13:12 ` Daniel Golle
2019-04-09 11:37 ` [PATCH 16/21] rt2x00: rt2800lib: use correct [RT]XWI size " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 17/21] rt2x00: rt2800lib: fix antenna configuration " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 18/21] rt2x00: rt2800lib: fix LNA gain " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 19/21] rt2x00: rt2800lib: fix VGC setup " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 20/21] rt2x00: rt2800lib: fix EEPROM LNA validation " Stanislaw Gruszka
2019-04-09 11:37 ` [PATCH 21/21] rt2x00: rt2800lib: fix txpower compensation " Stanislaw Gruszka
2019-04-23 8:49 ` [PATCH 00/21] RT3883 support from OpenWrt Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410082241.GA2538@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).