From: Michal Hocko <mhocko@kernel.org>
To: Luca Coelho <luca@coelho.fi>
Cc: kvalo@codeaurora.org, johannes@sipsolutions.net,
emmanuel.grumbach@intel.com, linuxwifi@intel.com,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Shahar S Matityahu <shahar.s.matityahu@intel.com>
Subject: Re: [PATCH] iwlwifi: don't panic in error path on non-msix systems
Date: Wed, 17 Apr 2019 12:59:47 +0200 [thread overview]
Message-ID: <20190417105947.GB5878@dhcp22.suse.cz> (raw)
In-Reply-To: <3c1cb224613ac2cc3b20bfcf0c47e0df584c4e31.camel@coelho.fi>
On Wed 17-04-19 13:17:10, Luca Coelho wrote:
> On Wed, 2019-04-17 at 12:11 +0200, Michal Hocko wrote:
> > Hi,
> > which tree is this supposed to be applied on? It doesn't do apply on
> > top
> > of v5.1-rc4-3-gfd008d1a7a20. iwl_trans_pcie_sync_nmi doesn't exist in
> > drivers/net/wireless/intel/iwlwifi/pcie/trans.c. iwl_trans_sync_nmi
> > looks pretty similar. My patch massaging ended up with this. Please
> > double check. It compiles and even boots.
>
> Ah, sorry, I didn't mention that that patch was supposed to apply on
> top of wireless-drivers-next, which is on its way to v5.2. We have
> other patches touching this function there, thus the conflict.
This is hard to tell. I haven't seen any "Error sending SCAN_CFG_CMD:"
message in the kernel log yet and I believe this is related to the
crash. But I might be easily wrong here.
In any case, I suspect that those events usually happen in a different
wireless environment than I am running right now. So give me some more
time before I can be more confident with an answer.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-04-17 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 21:07 iwlwifi: BUG: unable to handle kernel paging request at ffffc90000e1c808 Michal Hocko
2019-04-12 9:49 ` Michal Hocko
2019-04-16 18:36 ` Michal Hocko
2019-04-17 7:33 ` Luca Coelho
2019-04-17 7:35 ` [PATCH] iwlwifi: don't panic in error path on non-msix systems Luca Coelho
2019-04-17 10:11 ` Michal Hocko
2019-04-17 10:17 ` Luca Coelho
2019-04-17 10:53 ` Luca Coelho
2019-04-17 10:59 ` Michal Hocko [this message]
2019-04-22 18:07 ` Michal Hocko
2019-04-22 23:56 ` Kirtika Ruchandani
2019-04-23 2:34 ` Kirtika Ruchandani
2019-04-23 13:27 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417105947.GB5878@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luca@coelho.fi \
--cc=shahar.s.matityahu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox