From: Stanislaw Gruszka <sgruszka@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Subject: Re: [RFC 2/3] mt76usb: fix tx/rx stop
Date: Tue, 23 Apr 2019 09:59:50 +0200 [thread overview]
Message-ID: <20190423075949.GA5727@redhat.com> (raw)
In-Reply-To: <20190416091305.4218-3-sgruszka@redhat.com>
On Tue, Apr 16, 2019 at 11:13:04AM +0200, Stanislaw Gruszka wrote:
> -EXPORT_SYMBOL_GPL(mt76u_stop_queues);
> + tasklet_kill(&dev->usb.tx_tasklet);
> +
> + /* On phisical device removal we do not get tx complete
> + * callbacks, need to complete our skb's manually.
> + */
FTR: this comment is wrong, we can have queued skb's on device removal,
but not due to not having urb complete callback, but due to kick fail
to submit urb's.
Stanislaw
next prev parent reply other threads:[~2019-04-23 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 9:13 [RFC 0/3] mt76: suspend/stop/removal fixes Stanislaw Gruszka
2019-04-16 9:13 ` [RFC 1/3] mt76x02u: remove bogus stop on suspend Stanislaw Gruszka
2019-04-16 9:13 ` [RFC 2/3] mt76usb: fix tx/rx stop Stanislaw Gruszka
2019-04-23 7:59 ` Stanislaw Gruszka [this message]
2019-04-16 9:13 ` [RFC 3/3] mt76x02: remove bogus mutex usage Stanislaw Gruszka
2019-04-16 9:29 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423075949.GA5727@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).