From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E485C004C9 for ; Mon, 29 Apr 2019 14:26:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1F7A216FD for ; Mon, 29 Apr 2019 14:26:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="m6bVYXu6"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="niUyj4zt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728318AbfD2O05 (ORCPT ); Mon, 29 Apr 2019 10:26:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46904 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728276AbfD2O04 (ORCPT ); Mon, 29 Apr 2019 10:26:56 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 81B08608D4; Mon, 29 Apr 2019 14:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556548016; bh=IV0ZG6ry64zXhiRgrGKXvLnELJTpAeh9g3O3T8TohQw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=m6bVYXu6hdBpom4N8mp3+cdHioWWWIqFuuWXoycN+K7ZN4BR91NbFENodyX6XqPjR hnMfcW4rjMt7/1aEkoAGbhL6telhZzrnuVlXtST1JkY5i/W3j6nbMHNad/NauOYHBw O1K1viBbWet0mB+fFRHQO3Y/5MqutWc84pJ0/f/Q= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EE3DD607DF; Mon, 29 Apr 2019 14:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556548014; bh=IV0ZG6ry64zXhiRgrGKXvLnELJTpAeh9g3O3T8TohQw=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=niUyj4ztBOldr2anyLvHJxl/K8lZPA503ruQC6k8aQ0gJeJRmqwuBVGdsAjOs6fSB IKJ0Lf/JDBEJvf8LDRCiR4aWS/otNSaty53YiCnj3KyWGDmAzkqxqkneiEXDhxcUt4 9H3gzKHCwPG0awntrOGZUFAeuGE0+434DxJwBOHs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EE3DD607DF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume From: Kalle Valo In-Reply-To: <2884043.Jv1Mn93hE8@aspire.rjw.lan> References: <2884043.Jv1Mn93hE8@aspire.rjw.lan> To: "Rafael J. Wysocki" Cc: Linux PM , Srinivas Pandruvada , ath10k@lists.infradead.org, Todd Brandt , linux-wireless@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190429142655.81B08608D4@smtp.codeaurora.org> Date: Mon, 29 Apr 2019 14:26:55 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Rafael J. Wysocki" wrote: > ath10k_mac_vif_chan() always returns an error for the given vif > during system-wide resume which reliably triggers two WARN_ON()s > in ath10k_bss_info_changed() and they are not particularly > useful in that code path, so drop them. > > Tested: QCA6174 hw3.2 PCI with WLAN.RM.2.0-00180-QCARMSWPZ-1 > Tested: QCA6174 hw3.2 SDIO with WLAN.RMH.4.4.1-00007-QCARMSWP-1 > > Fixes: cd93b83ad927 ("ath10k: support for multicast rate control") > Fixes: f279294e9ee2 ("ath10k: add support for configuring management packet rate") > Cc: stable@vger.kernel.org > Reviewed-by: Brian Norris > Tested-by: Brian Norris > Tested-by: Claire Chang > Signed-off-by: Rafael J. Wysocki > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. 9e80ad37f678 ath10k: Drop WARN_ON()s that always trigger during system resume -- https://patchwork.kernel.org/patch/10837139/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches