From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [RFC] rtlwifi: rtl8821ae: Use inline routines rather than macros for descriptor word 0
Date: Tue, 7 May 2019 14:36:07 +0200 [thread overview]
Message-ID: <20190507123606.GA5076@redhat.com> (raw)
In-Reply-To: <20190506173916.16486-1-Larry.Finger@lwfinger.net>
On Mon, May 06, 2019 at 12:39:16PM -0500, Larry Finger wrote:
> The driver uses complicated macros to set parts of word 0 of the TX and RX
> descriptors. These are changed into inline routines.
Why not use le32p_replace_bits() like rtw88 in
drivers/net/wireless/realtek/rtw88/tx.h ?
Stanislaw
next prev parent reply other threads:[~2019-05-07 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 17:39 [RFC] rtlwifi: rtl8821ae: Use inline routines rather than macros for descriptor word 0 Larry Finger
2019-05-07 12:36 ` Stanislaw Gruszka [this message]
2019-05-28 12:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507123606.GA5076@redhat.com \
--to=sgruszka@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).