From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/4] mt76: mt76x2: move mutex_lock inside mt76x2_set_channel
Date: Mon, 13 May 2019 10:37:56 +0200 [thread overview]
Message-ID: <20190513083755.GA13726@redhat.com> (raw)
In-Reply-To: <1527e88fc4a307aa218f515811f2f2c15786caec.1557567465.git.lorenzo@kernel.org>
On Sat, May 11, 2019 at 12:17:53PM +0200, Lorenzo Bianconi wrote:
> This is a preliminary patch to run mt76x02_edcca_init atomically
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../wireless/mediatek/mt76/mt76x2/pci_main.c | 16 ++++++++------
> .../wireless/mediatek/mt76/mt76x2/usb_main.c | 22 ++++++++++---------
> 2 files changed, 21 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c b/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c
> index e416eee6a306..3a1467326f4d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/pci_main.c
> @@ -54,14 +54,14 @@ mt76x2_set_channel(struct mt76x02_dev *dev, struct cfg80211_chan_def *chandef)
> int ret;
>
> cancel_delayed_work_sync(&dev->cal_work);
Since now you use mutex in mt76x2_phy_calibrate() you can remove
cancel_delayed_work_sync() and drop other changes from this patch
as releasing mutex just to acquire it in almost next step make
no sense.
Stanislaw
next prev parent reply other threads:[~2019-05-13 8:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 10:17 [PATCH 0/4] run mt76x02_edcca_init atomically Lorenzo Bianconi
2019-05-11 10:17 ` [PATCH 1/4] mt76: mt76x02: remove enable from mt76x02_edcca_init signature Lorenzo Bianconi
2019-05-11 10:17 ` [PATCH 2/4] mt76: mt76x2u: remove mt76x02_edcca_init in mt76x2u_set_channel Lorenzo Bianconi
2019-05-11 10:17 ` [PATCH 3/4] mt76: mt76x2: move mutex_lock inside mt76x2_set_channel Lorenzo Bianconi
2019-05-13 8:37 ` Stanislaw Gruszka [this message]
2019-05-13 9:19 ` Lorenzo Bianconi
2019-05-13 9:30 ` Felix Fietkau
2019-05-13 9:41 ` Stanislaw Gruszka
2019-05-11 10:17 ` [PATCH 4/4] mt76: mt76x02: run mt76x02_edcca_init atomically in mt76_edcca_set Lorenzo Bianconi
2019-05-11 14:22 ` Felix Fietkau
2019-05-11 14:29 ` Lorenzo Bianconi
2019-05-11 14:30 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513083755.GA13726@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).