From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC63C04E53 for ; Wed, 15 May 2019 09:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D923720881 for ; Wed, 15 May 2019 09:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726170AbfEOJdr (ORCPT ); Wed, 15 May 2019 05:33:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfEOJdr (ORCPT ); Wed, 15 May 2019 05:33:47 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C1EC307EA91; Wed, 15 May 2019 09:33:47 +0000 (UTC) Received: from localhost (unknown [10.43.2.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70A70196F3; Wed, 15 May 2019 09:33:36 +0000 (UTC) Date: Wed, 15 May 2019 11:33:34 +0200 From: Stanislaw Gruszka To: Lorenzo Bianconi Cc: Kalle Valo , nbd@nbd.name, lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca Message-ID: <20190515093333.GA2333@redhat.com> References: <0691acb931e963cb6028d4687cdd61032d0aaf52.1557591530.git.lorenzo@kernel.org> <87r293ugia.fsf@purkki.adurom.net> <20190513084127.GA3127@localhost.localdomain> <20190513094837.GB15694@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190513094837.GB15694@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 15 May 2019 09:33:47 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, May 13, 2019 at 11:48:37AM +0200, Stanislaw Gruszka wrote: > On Mon, May 13, 2019 at 10:41:28AM +0200, Lorenzo Bianconi wrote: > > > Lorenzo Bianconi writes: > > > > > > > Introduce a knob in mt7603 debugfs in order to enable/disable > > > > edcca processing > > > > > > > > Signed-off-by: Lorenzo Bianconi > > > > > > It's good to explain what edcca does and how the file is used supposed > > > to be used. In other words, have a small introduction for the user. > > > > Hi Kalle, > > > > edcca is used for adjusting energy detect based on CCA thresholds. > > The code was already there so I just reported the acronym. > > What for it is needed ? Care to comment why EDCCA is needed at all ? Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests. Stanislaw