From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64736C04E53 for ; Wed, 15 May 2019 09:56:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37F0F2084A for ; Wed, 15 May 2019 09:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726464AbfEOJ4I (ORCPT ); Wed, 15 May 2019 05:56:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfEOJ4I (ORCPT ); Wed, 15 May 2019 05:56:08 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0C36F3086212; Wed, 15 May 2019 09:56:08 +0000 (UTC) Received: from localhost (unknown [10.43.2.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91EA919C71; Wed, 15 May 2019 09:56:05 +0000 (UTC) Date: Wed, 15 May 2019 11:54:41 +0200 From: Stanislaw Gruszka To: Lorenzo Bianconi Cc: Kalle Valo , nbd@nbd.name, lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca Message-ID: <20190515095440.GB3407@redhat.com> References: <0691acb931e963cb6028d4687cdd61032d0aaf52.1557591530.git.lorenzo@kernel.org> <87r293ugia.fsf@purkki.adurom.net> <20190513084127.GA3127@localhost.localdomain> <20190513094837.GB15694@redhat.com> <20190515093333.GA2333@redhat.com> <20190515094354.GA30757@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515094354.GA30757@localhost.localdomain> User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 15 May 2019 09:56:08 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, May 15, 2019 at 11:43:55AM +0200, Lorenzo Bianconi wrote: > > On Mon, May 13, 2019 at 11:48:37AM +0200, Stanislaw Gruszka wrote: > > > On Mon, May 13, 2019 at 10:41:28AM +0200, Lorenzo Bianconi wrote: > > > > > Lorenzo Bianconi writes: > > > > > > > > > > > Introduce a knob in mt7603 debugfs in order to enable/disable > > > > > > edcca processing > > > > > > > > > > > > Signed-off-by: Lorenzo Bianconi > > > > > > > > > > It's good to explain what edcca does and how the file is used supposed > > > > > to be used. In other words, have a small introduction for the user. > > > > > > > > Hi Kalle, > > > > > > > > edcca is used for adjusting energy detect based on CCA thresholds. > > > > The code was already there so I just reported the acronym. > > > > > > What for it is needed ? > > > > Care to comment why EDCCA is needed at all ? > > > > Taking that debugfs file that enable it is read-only, it looks like > > feature that nobody needs nor tests. > > already fixed in v2 > https://patchwork.kernel.org/patch/10940645/ I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ? Stanislaw