From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Lior Cohen <lior2.cohen@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 7/7] iwlwifi: mvm: change TLC config cmd sent by rs to be async
Date: Wed, 29 May 2019 16:39:55 +0300 [thread overview]
Message-ID: <20190529133955.31082-8-luca@coelho.fi> (raw)
In-Reply-To: <20190529133955.31082-1-luca@coelho.fi>
From: Lior Cohen <lior2.cohen@intel.com>
The TLC_MNG_CONFIG sync cmd sent by the rs leads to a kernel warning
of sleeping while in rcu read-side critical section. The fix is to
change the command to be ASYNC (not blocking for the response anymore).
Signed-off-by: Lior Cohen <lior2.cohen@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c
index 659e21b2d4e7..be62f499c595 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c
@@ -441,7 +441,8 @@ void rs_fw_rate_init(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
*/
sta->max_amsdu_len = max_amsdu_len;
- ret = iwl_mvm_send_cmd_pdu(mvm, cmd_id, 0, sizeof(cfg_cmd), &cfg_cmd);
+ ret = iwl_mvm_send_cmd_pdu(mvm, cmd_id, CMD_ASYNC, sizeof(cfg_cmd),
+ &cfg_cmd);
if (ret)
IWL_ERR(mvm, "Failed to send rate scale config (%d)\n", ret);
}
--
2.20.1
prev parent reply other threads:[~2019-05-29 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 13:39 [PATCH 0/7] wlwifi: fixes intended for 5.2 2019-05-29 Luca Coelho
2019-05-29 13:39 ` [PATCH 1/7] iwlwifi: mvm: remove d3_sram debugfs file Luca Coelho
2019-06-01 5:05 ` Kalle Valo
2019-05-29 13:39 ` [PATCH 2/7] iwlwifi: fix load in rfkill flow for unified firmware Luca Coelho
2019-05-29 13:39 ` [PATCH 3/7] iwlwifi: clear persistence bit according to device family Luca Coelho
2019-05-29 13:39 ` [PATCH 4/7] iwlwifi: print fseq info upon fw assert Luca Coelho
2019-05-29 14:39 ` Kalle Valo
2019-06-01 11:13 ` Luca Coelho
2019-05-29 13:39 ` [PATCH 5/7] iwlwifi: fix AX201 killer sku loading firmware issue Luca Coelho
2019-05-29 13:39 ` [PATCH 6/7] iwlwifi: Fix double-free problems in iwl_req_fw_callback() Luca Coelho
2019-05-29 13:39 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529133955.31082-8-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lior2.cohen@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).