From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3132C28CC1 for ; Sat, 1 Jun 2019 05:06:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76C7F27123 for ; Sat, 1 Jun 2019 05:06:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EX2PI6rn"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NvtHx5n4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726009AbfFAFGr (ORCPT ); Sat, 1 Jun 2019 01:06:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50430 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbfFAFGr (ORCPT ); Sat, 1 Jun 2019 01:06:47 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C6CE060C72; Sat, 1 Jun 2019 05:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559365606; bh=0rQKj4Z3TH7f4HqARwB1c8TiOOWdm0uC/zyCjBgDN0E=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=EX2PI6rn6lOCV7bhASc58a20SVYSyp6fC67xW7j9icbWZRV/E8DG2FdrsbHLCSX0R 9iW3k+dfwg/R0rlTG2o4Gc1+3igb1Ha+Ausxci4S+HYMgwbKYazon/mYucRc9ReQpj 9LkZgHd3hHzmhyNjLYsrFZgqYVFMdy8t/rcFkcas= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AB0F660312; Sat, 1 Jun 2019 05:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559365604; bh=0rQKj4Z3TH7f4HqARwB1c8TiOOWdm0uC/zyCjBgDN0E=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=NvtHx5n4opRad6Swy7wfOsRPCJQ8f4Y5ebWV+xtbpAHH9/9duAytd+1LB+DYPJN1v DXQYrCDfbEk9OIU0rotwLSizdRV+9IdANgaZIG0IM6HmN7hyJF6FI1TKYe2JkokZVt ZDz8xpCplWPjTmJSRWzy5leYH6cohejtZeOgLogs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AB0F660312 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mwifiex: Fix heap overflow in mwifiex_uap_parse_tail_ies() From: Kalle Valo In-Reply-To: <20190531131841.7552-1-tiwai@suse.de> References: <20190531131841.7552-1-tiwai@suse.de> To: Takashi Iwai Cc: Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , huangwen , Solar Designer , Marcus Meissner , linux-wireless@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190601050646.C6CE060C72@smtp.codeaurora.org> Date: Sat, 1 Jun 2019 05:06:46 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Takashi Iwai wrote: > A few places in mwifiex_uap_parse_tail_ies() perform memcpy() > unconditionally, which may lead to either buffer overflow or read over > boundary. > > This patch addresses the issues by checking the read size and the > destination size at each place more properly. Along with the fixes, > the patch cleans up the code slightly by introducing a temporary > variable for the token size, and unifies the error path with the > standard goto statement. > > Reported-by: huangwen > Signed-off-by: Takashi Iwai Patch applied to wireless-drivers.git, thanks. 69ae4f6aac15 mwifiex: Fix heap overflow in mwifiex_uap_parse_tail_ies() -- https://patchwork.kernel.org/patch/10970141/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches