From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65CDFC43218 for ; Mon, 10 Jun 2019 18:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49FD620820 for ; Mon, 10 Jun 2019 18:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388109AbfFJSux (ORCPT ); Mon, 10 Jun 2019 14:50:53 -0400 Received: from bues.ch ([80.190.117.144]:52898 "EHLO bues.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387643AbfFJSux (ORCPT ); Mon, 10 Jun 2019 14:50:53 -0400 Received: by bues.ch with esmtpsa (Exim 4.89) (envelope-from ) id 1haPNS-0002VR-Rf; Mon, 10 Jun 2019 20:50:42 +0200 Date: Mon, 10 Jun 2019 20:49:27 +0200 From: Michael =?UTF-8?B?QsO8c2No?= To: Kalle Valo Cc: H Buus , Larry Finger , linux-wireless Subject: [PATCH] ssb/gpio: Remove unnecessary WARN_ON from driver_gpio Message-ID: <20190610204927.2de21c9a@wiggum> In-Reply-To: <946c86bf-7e90-a981-b9fc-757adb98adfa@hbuus.com> References: <946c86bf-7e90-a981-b9fc-757adb98adfa@hbuus.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/=aAChw9jp+ZBq/eLygL=Q5F"; protocol="application/pgp-signature" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --Sig_/=aAChw9jp+ZBq/eLygL=Q5F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. The warning serves no purpose. So let's just remove it. Reported-by: H Buus Signed-off-by: Michael B=C3=BCsch --- diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c index e809dae4c470..66a76fd83248 100644 --- a/drivers/ssb/driver_gpio.c +++ b/drivers/ssb/driver_gpio.c @@ -460,9 +460,6 @@ int ssb_gpio_init(struct ssb_bus *bus) return ssb_gpio_chipco_init(bus); else if (ssb_extif_available(&bus->extif)) return ssb_gpio_extif_init(bus); - else - WARN_ON(1); - return -1; } =20 @@ -472,9 +469,6 @@ int ssb_gpio_unregister(struct ssb_bus *bus) ssb_extif_available(&bus->extif)) { gpiochip_remove(&bus->gpio); return 0; - } else { - WARN_ON(1); } - return -1; } --Sig_/=aAChw9jp+ZBq/eLygL=Q5F Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAlz+pjcACgkQ9TK+HZCN iw4Jdg//ehl1NpCjzEposBgzTwIUcrTrVMIOb7pM6uWKtJXJvy6Z8OypBgHXA5av P8r26xazFPf5mzAV0HLNyRJkx8yYK7D9a0mwh6fFaWtiNtiefxCrdJePUiradRZU TFvyXMCx7Qrnl4K9FjYTO+KF3m5ixLY2zjIPXVeKuydPz4xQj2oz0vO6l3YS2Bim nELFrX4pCwzHtJSIHKuPgi80DGBI0aAVyyvE5nRDOuDq8AnDn70aLARvXy715COZ dzfRPYinum/PBFLlkcV62YAtD/8enMiptj1vv67vKsImaYADatTnorTdqHGOJ/zB upvdr4iEQuBTtv2WuR/82Ui/gxwI9cz87HbQ7aLRDNqSlsDAqHCD81+K/djzYRe+ 2e4GTfVGV3/GTs5QdvC6jEOd9XfVTLkqMQs6USET58RxZrdnbaAhfdMVzexylw0H MnZMsEawL7TdFoE7fR+Lix9o9cO2tDt0Q9KUqnfQOnYlMWVqHkCmrLp1XD5oqXz8 Rct7FMmEgfF1GXYbXBzqo8pdW0IB2RtMC6Al0VXeQwHQUdVRqN94z0+2JOjo/sxl NDw/TOn9h+llDYNFEehOOZHbhkVjIrq34E7WUWxTDEqYI0XqAZgYRqWaJgzfW8dW 8P+PgzRXcM07vl/JyC84cLXKMgYvkLaoUcGf5PlHLbN15vJQvDw= =wwDB -----END PGP SIGNATURE----- --Sig_/=aAChw9jp+ZBq/eLygL=Q5F--